🐛 BUG: unstable_dev ignores persist flag (when disabling)

[its-jman]

Which Cloudflare product(s) does this pertain to?

Wrangler core

What version(s) of the tool(s) are you using?

3.3.0

What version of Node are you using?

No response

What operating system are you using?

Mac

Describe the Bug

When using unstable_dev in tests, I've run into an issue where it is persisting states across test runs.

I have been able to resolve it by patching wrangler locally to always disable persisting, but the problem originates here. startDevServer only accepts localPersistencePath as a prop, but getLocalPersistencePath function only checks persistTo, not persist here:

diff --git a/node_modules/wrangler/wrangler-dist/cli.js b/node_modules/wrangler/wrangler-dist/cli.js
index 7e70023..4a6c9dd 100644
--- a/node_modules/wrangler/wrangler-dist/cli.js
+++ b/node_modules/wrangler/wrangler-dist/cli.js
@@ -149668,7 +149668,7 @@ async function startApiDev(args) {
       upstreamProtocol,
       localProtocol: args.localProtocol ?? configParam.dev.local_protocol,
       localUpstream: args.localUpstream ?? host,
-      localPersistencePath,
+      localPersistencePath: null,
       liveReload: args.liveReload ?? false,
       accountId: configParam.account_id ?? getAccountFromCache()?.id,
       assetPaths,

---

This is the code to replicate

worker = await unstable_dev('./src/__test__/worker1.ts', {
	persist: false,
	experimental: {disableExperimentalWarning: true, disableDevRegistry: true},
	durableObjects: [
		{
			class_name: 'Storage',
			name: 'STORAGE',
		},
	],
})

Please provide a link to a minimal reproduction

No response

Please provide any relevant error logs

No response

[admah]

Hello @its-jman 👋 Sorry for the delay on getting back to you about this issue. This looks to be a result of removing the --persist flag in v3. We'll take a look into the best way to handle this moving forward.

cc: @mrbbot @RamIdeas