Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 BUG: bump node engines to v18 in c3 #3932

Closed
IgorMinar opened this issue Sep 12, 2023 · 0 comments · Fixed by #4063
Closed

🚀 BUG: bump node engines to v18 in c3 #3932

IgorMinar opened this issue Sep 12, 2023 · 0 comments · Fixed by #4063
Assignees
@jculvey
Labels
c3 Relating to C3 (create-cloudflare) package enhancement New feature or request

Comments

@IgorMinar
Copy link
Contributor

Describe the solution

We currently test c3 on node 18 but in package.json we claim node 16 support.

Since node 16 is now obsolete we should bump the engines to 18, this will issue an installation warning to users that still use 16.
@IgorMinar IgorMinar added enhancement New feature or request c3 Relating to C3 (create-cloudflare) package labels Sep 12, 2023
@IgorMinar IgorMinar changed the title 🚀 Bug: bump node engines to v18 in c3 🚀 BUG: bump node engines to v18 in c3 Sep 12, 2023
@jculvey jculvey mentioned this issue Sep 28, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jculvey jculvey

Labels
c3 Relating to C3 (create-cloudflare) package enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

C3: Bump node engines version in package.json cloudflare/workers-sdk
2 participants
@jculvey @IgorMinar