Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature Request: Hyperdrive should have default ports for schemes (i.e 5432 for postgres) #4059

Closed
KianNH opened this issue Sep 28, 2023 · 2 comments
Closed

🚀 Feature Request: Hyperdrive should have default ports for schemes (i.e 5432 for postgres) #4059

KianNH opened this issue Sep 28, 2023 · 2 comments
Assignees
@elithrar
Labels
awaiting Cloudflare response Awaiting response from workers-sdk maintainer team enhancement New feature or request

Comments

@KianNH
Copy link
Contributor

KianNH commented Sep 28, 2023

Describe the solution

Good catch, yes. We should fix to avoid needing to specify it for Postgres and just default to 5432 in those cases.

Originally posted by @elithrar in cloudflare/cloudflare-docs#10980 (comment)
@KianNH KianNH added the enhancement New feature or request label Sep 28, 2023
@KianNH KianNH mentioned this issue Sep 28, 2023
Merged
@lrapoport-cf
Copy link
Contributor

hi @elithrar , can your team take a look at this?

@lrapoport-cf lrapoport-cf added the awaiting Cloudflare response Awaiting response from workers-sdk maintainer team label Oct 9, 2023
@KianNH
Copy link
Contributor Author

KianNH commented Oct 9, 2023

It looks like this was solved today by @a-robinson in #4069

@KianNH KianNH closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elithrar elithrar

Labels
awaiting Cloudflare response Awaiting response from workers-sdk maintainer team enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elithrar @KianNH @lrapoport-cf