This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Improve heuristic for --openssl-legacy-provider (#2155) #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a very nice solution! I'm afk at the moment, but can I trust that you've tested this for versions that require and don't require the flag? Happy to merge if so. |
|
Yup, tested |
threepointone
approved these changes
Jan 3, 2022
|
Thanks again for this PR! We'll do a release soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the heuristic for detecting whether we need
--openssl-legacy-provideradded in #2116 by also checking whether the Node.js was actually built against OpenSSL 3 and has that option available.Fixes #2155.