From d1c92cbbbb9d2392dad57d2e2192fc0c0e7cf1ed Mon Sep 17 00:00:00 2001
From: Dimitris Karakasilis <DKarakasilis@suse.com>
Date: Fri, 21 Aug 2020 10:24:21 +0300
Subject: [PATCH] Remove "version: every" when "passed:" contraints are defined

because that blocks automatic triggering of jobs

https://github.com/concourse/concourse/issues/736

This combination of settting was introduced when we tried to force
Concourse to run later jobs on every version that passed the previous
one. E.g.
ver1 passed job 1, ver2 passed job 1
job2 should trigger both for ver1 and ver2 otherwise ver1 would never
be tested on job2. The new scheduling algorighm may have solved this:

https://concourse-ci.org/scheduler.html#scheduling-behavior

Given our pipeline needs us to manually trigger jobs all the time, this
worths a shot.
---
 .concourse/pipeline.yaml.gomplate | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/.concourse/pipeline.yaml.gomplate b/.concourse/pipeline.yaml.gomplate
index b976bf1591..49b5849cad 100644
--- a/.concourse/pipeline.yaml.gomplate
+++ b/.concourse/pipeline.yaml.gomplate
@@ -391,7 +391,6 @@ jobs:
     - {{ . -}}{{ end }}
     {{- end }}
     trigger: true
-    version: "every"
     passed:
     - lint-{{ $branch }}
 {{- if has $config.stable_jobs "build" }}
@@ -489,7 +488,6 @@ jobs:
     - {{ . -}}{{ end }}
     {{- end }}
     trigger: true
-    version: "every"
     passed:
     - build-{{ $branch }}
   - get: s3.kubecf-ci
@@ -722,7 +720,6 @@ jobs:
     - {{ . -}}{{ end }}
     {{- end }}
     trigger: true
-    version: "every"
     passed:
     - deploy-{{ $cfScheduler }}-{{ $branch }}
   - get: s3.kubecf-ci
@@ -901,7 +898,6 @@ jobs:
     passed:
     - {{ $previousTest | quote }}
     trigger: true
-    version: "every"
   - get: s3.kubecf-ci
     {{- if $config.workertags }}
     tags: {{ range $config.workertags }}
@@ -1068,7 +1064,6 @@ jobs:
     passed:
     - {{ $previousTest | quote }}
     trigger: true
-    version: "every"
   - get: s3.kubecf-ci
     {{- if $config.workertags }}
     tags: {{ range $config.workertags }}
@@ -1238,7 +1233,6 @@ jobs:
     passed:
     - {{ $previousTest | quote }}
     trigger: true
-    version: "every"
   - get: s3.kubecf-ci
     {{- if $config.workertags }}
     tags: {{ range $config.workertags }}
@@ -1406,7 +1400,6 @@ jobs:
     passed:
     - {{ $previousTest | quote }}
     trigger: true
-    version: "every"
   - get: s3.kubecf-ci
     {{- if $config.workertags }}
     tags: {{ range $config.workertags }}
@@ -1572,7 +1565,6 @@ jobs:
     passed:
     - {{ $previousTest | quote }}
     trigger: true
-    version: "every"
   - get: s3.kubecf-ci
     {{- if $config.workertags }}
     tags: {{ range $config.workertags }}
@@ -1736,7 +1728,6 @@ jobs:
 #     passed:
 #     - sync-integration-tests-{{ $cfScheduler }}
 #     trigger: true
-#     version: "every"
 #   - get: s3.kubecf-ci
 #     passed:
 #     - sync-integration-tests-{{ $cfScheduler }}
@@ -1803,7 +1794,6 @@ jobs:
     passed:
     - {{ $previousTest | quote }}
     trigger: true
-    version: "every"
   - get: semver.gke-cluster-{{ $config.resource_prefix | strings.Trunc 12 }}-{{ $branch | strings.Trunc 12 }}-{{ $cfScheduler }}
     {{- if $config.workertags }}
     tags: {{ range $config.workertags }}
@@ -1839,7 +1829,6 @@ jobs:
       - {{ . -}}{{ end }}
       {{- end }}
       trigger: true
-      version: "every"
       passed:
       - build-{{ $branch }}
     - get: s3.kubecf-ci