Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match release-build-sign-upload.yml to other branches #2711

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

moleske
Copy link
Member

@moleske moleske commented Dec 18, 2023

  • removed some commented out text

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Where this PR should be backported?

  • main - all changes should by default start here
  • v8
  • v7

Description of the Change

Match the release logic in the other branches

Why Is This PR Valuable?

Keeps all the branches using the same release logic

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

Who else is affected by the change?

- removed some commented out text

Co-authored-by: david alvarado <alvaradoda@vmware.com>
@ccjaimes ccjaimes merged commit f21d988 into v7 Dec 19, 2023
13 checks passed
@moleske moleske deleted the sync-build-sign-upload-v7 branch December 19, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants