Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change windows release build and sign to use Digicert Keylocker signi… #2765

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

moleske
Copy link
Member

@moleske moleske commented Feb 1, 2024

…ng mechanism

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Where this PR should be backported?

  • main - all changes should by default start here
  • v8
  • v7

Description of the Change

The old key for signing windows artifacts has expired and digicert changed their method of signing. So this updates it

Why Is This PR Valuable?

Users won't see scary warnings when getting the cf cli on windows

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

The key is currently expired, so sooner is better

Other Relevant Parties

Who else is affected by the change?

Copy link
Contributor

@pivotalgeorge pivotalgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The windows changes in this workflow match the passing signing run within pivotal-cf/cli#windows-signing-via-keylocker-v8, the branch of the repository currently building and signing v8 cli artifacts for release.

…ng mechanism

Co-Authored-By: Michael Oleske <michael.oleske@broadcom.com>
Co-Authored-By: Al Berez <al.berez@broadcom.com>
@moleske moleske force-pushed the windows-signing-via-keylocker-v8 branch from ea77bd1 to 72c9509 Compare February 5, 2024 21:40
@a-b a-b merged commit e82a63d into v8 Feb 7, 2024
13 checks passed
@a-b a-b deleted the windows-signing-via-keylocker-v8 branch February 7, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants