Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore]: E2E tests should wait for spaces and orgs to finish deleting successfully #2636

Closed
matt-royal opened this issue Jun 24, 2023 · 1 comment
Labels
Milestone

Comments

@matt-royal
Copy link
Member

Background

We've recently discovered a number of issues with space and org deletion, where resources can be orphaned or the space/org can fail to ever finish deleting due to unfinalized resources in their namespace. This change will ensure that we catch these problems in the future if they recur

Action to take

Change the space and org teardown logic in the e2e tests so that it checks the job status for the deletion and ensures that it succeeds. Once #2604 and #2605 are complete, this will ensure that the spaces and orgs are actually deleted. Tests should fail if the deletion doesn't complete in a reasonable amount of time.

Impact

We'll catch issues with deleting spaces and orgs more quickly.

Dev Notes

The simplest way to accomplish this is likely by changing the deleteSpace and deleteOrg helpers

@matt-royal matt-royal added this to the v0.8 milestone Jun 24, 2023
@matt-royal matt-royal changed the title E2E tests should wait for spaces and orgs to finish deleting successfully [Chore]: E2E tests should wait for spaces and orgs to finish deleting successfully Jun 24, 2023
@matt-royal matt-royal modified the milestones: v0.8, v0.9 Jun 27, 2023
@matt-royal
Copy link
Member Author

After some discussion amongst the AMER team, we don't think we should execute this chore, so I'm closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

1 participant