-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Migrate tests from JavaScript to TypeScript #173
Comments
Happy to discuss/tackle this if you want to move forward with this. |
mixed feelings on this one. i dont love the idea of having to painstakingly define types for everything in the tests when tests can be a pain to get up and running sometimes in the first place. thinking about the extra loops someone would have to jump through sometimes to get this up and running that said, thats an assumption and i haven't written tests in TS before, is that a fair assumption? |
You shouldn't have to explicitly type a lot of things. Maybe some mock data would need to be cast sometimes where you don't have all the data that it actually expects. I can do a little POC to show a before and after. |
id be down for a POC if you dont mind spending the time! |
I'm still a little swamped at work, but can still look at this. That said if someone comes along before me, feel free to let them do the POC. |
While fixing #170, I was trying to get some type errors by putting invalid gravity values in the test suite until I realized they were written in JS.
Consider converting the test suites to TypeScript.
The text was updated successfully, but these errors were encountered: