-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add restriction to only run for PRs with main as the target. #86
Conversation
The intent is to facilitate the integration of external forks opening PRs.
|
@zacharyDez can you explain the duplication of code across jobs in the workflow? also the json samples posted in the comments for success and fail appear to be identical - typo in copying? |
Mishaps on my side, @wildintellect . Removed the duplicates and changed the example file in the comment! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the internals of github actions here, but looks fine
What I Changed
For background information: See #74.
The preview action on external forks has failed because the pr-preview-action does not support preview on external forks. Also, it intends to refrain from supporting in the future.
The PR changes the preview action to only run on PRs to main.
How I tested it
For the changes to
ci.yml
:pr-test-success.json
pr-test-fail.json
Run the workflows of the added job with: