Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor pull does not support double-star glob for exclusions or templating on the include/exclude list #835

Open
jamengual opened this issue Dec 9, 2024 · 2 comments
Assignees
Labels
feature New functionality Short List

Comments

@jamengual
Copy link

jamengual commented Dec 9, 2024

Describe the Bug

atmos vendor pull can't exclude subdirs.

If I have :

stacks/
  mystacks/
    us-east-1
     pepe1
     pepe2

and vendor yaml with :

exclude_paths:
  - "**/stacks/**/pepe2"

Atmos is not able to match the path of the subdir and it vendors all the files under pepe2 dir

it is also not possible to templatize the exclude or include paths, which is helpful when you have automated pipelines that can expose the names of dirs you want to exclude.

- "**/stacks/**/${exclude_me}"

That will be nice to have.

Atmos 1.110.0

Expected Behavior

Atmos should support regexes fully for the exclude and include paths

Steps to Reproduce

atmos vendor pull

Screenshots

No response

Environment

No response

Additional Context

No response

@jamengual jamengual added the bug 🐛 An issue with the system label Dec 9, 2024
@GabisCampana GabisCampana added the feature New functionality label Dec 9, 2024 — with Linear
@GabisCampana GabisCampana removed the bug 🐛 An issue with the system label Dec 9, 2024
@osterman osterman changed the title Vendor pull do not support subdir regex for exclusion or templating on the include/exclude list Vendor pull do not support subdir double-star glob for exclusion or templating on the include/exclude list Dec 9, 2024
@osterman osterman changed the title Vendor pull do not support subdir double-star glob for exclusion or templating on the include/exclude list Vendor pull does not support double-star glob for exclusions or templating on the include/exclude list Dec 9, 2024
@osterman
Copy link
Member

osterman commented Dec 9, 2024

@jamengual in this example, I'm a little bit confused by this: ${exclude_me} as that's not Go templating syntax and not sure what you would be referring to.

@jamengual
Copy link
Author

@jamengual in this example, I'm a little bit confused by this: ${exclude_me} as that's not Go templating syntax and not sure what you would be referring to.

My vendor file uses :

- source: 'git::https://x-access-token:{{env "GITHUB_TOKEN"}}@github.com/ORG/pepe-iac.git'

where the token comes from the github workflow.

supporting go-template could be even better.

@osterman osterman self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality Short List
Projects
None yet
Development

No branches or pull requests

3 participants