Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Custom Atmos Shell Prompts inside Geodesic #837

Open
coderabbitai bot opened this issue Dec 9, 2024 · 1 comment
Open

Implement Custom Atmos Shell Prompts inside Geodesic #837

coderabbitai bot opened this issue Dec 9, 2024 · 1 comment
Assignees

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2024

As discussed in PR #827, we need to solve for custom Atmos shell prompts inside Geodesic.

// This means you cannot have a custom shell prompt inside Geodesic (Geodesic requires "-l").
// Perhaps we should have special detection for Geodesic?
// We could test if env var GEODESIC_SHELL is set to "true" (or set at all).
if !hasCustomShellPrompt {
shellCommand = shellCommand + " -l"
}

@Nuru Nuru changed the title Implement Geodesic shell detection in Atmos Implement Custom Atmos Shell Prompts inside Geodesic Dec 9, 2024
@osterman
Copy link
Member

osterman commented Dec 9, 2024

@Nuru what if we added support for custom args to the shell, to make it more configurable:

In atmos.yml we already support a configuration section for the prompt.

components:
  terraform:
    shell:
      prompt: ...
      args: "-l"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants