Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass cache_bucket_suffix_enabled through to codebuild module #80

Merged

Conversation

inhumantsar
Copy link
Contributor

what

  • cache_bucket_suffix_enabled was an accepted variable but wasn't passed through to codebuild.
  • defaulted cache_bucket_suffix_enabled to false

why

  • cache_bucket_suffix_enabled = true is the default on the codebuild module, but there's a bug which prevents that from working.

references

@inhumantsar inhumantsar requested review from a team as code owners August 1, 2021 19:36
@inhumantsar inhumantsar requested review from Gowiem and jamengual August 1, 2021 19:36
@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode merged commit 5deef6a into cloudposse:master Aug 2, 2021
inhumantsar added a commit to inhumantsar/terraform-aws-ecs-codepipeline that referenced this pull request Aug 3, 2021
…oudposse#80)

* fix: pass cache_bucket_suffix_enabled through to codebuild module

* update docs

* Auto Format

Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
inhumantsar added a commit to inhumantsar/terraform-aws-ecs-codepipeline that referenced this pull request Aug 13, 2021
…oudposse#80)

* fix: pass cache_bucket_suffix_enabled through to codebuild module

* update docs

* Auto Format

Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
inhumantsar added a commit to inhumantsar/terraform-aws-ecs-codepipeline that referenced this pull request Aug 13, 2021
…oudposse#80)

* fix: pass cache_bucket_suffix_enabled through to codebuild module

* update docs

* Auto Format

Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: cache location is required when cache type is "S3"
3 participants