Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support attribute-based instance type selection #95

Open
Nuru opened this issue Nov 5, 2021 · 4 comments
Open

Support attribute-based instance type selection #95

Nuru opened this issue Nov 5, 2021 · 4 comments

Comments

@Nuru
Copy link
Contributor

Nuru commented Nov 5, 2021

Support attribute-based instance type selection when the AWS Terraform provider supports it.
See AWS announcement

@nitrocode
Copy link
Member

Ticket to track hashicorp/terraform-provider-aws#21566

@jtdoepke
Copy link

Ticket to track hashicorp/terraform-provider-aws#21566

This has been closed/released in in AWS Provider v4.16.0

@nitrocode
Copy link
Member

nitrocode commented Jun 7, 2022

@jtdoepke cool, thanks for the heads up!

Looks like we can use the instance_requirements block on the launch template to make use of this feature.

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/launch_template#instance-requirements

The aws_launch_template resource says if we use instance_requirements then we cannot use instance_type argument.

We do not use instance_type on the launch template but we do use instance_types on the aws_eks_node_group.

resource "aws_eks_node_group" "default" {

instance_types = local.ng.instance_types

@nitrocode
Copy link
Member

@jtdoepke if you want to test this out, please take a look at the draft PR #120

@settings settings bot removed the feature request label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants