Skip to content

Commit

Permalink
Correctly extract security group name for tags (#24)
Browse files Browse the repository at this point in the history
  • Loading branch information
Nuru committed Oct 22, 2021
1 parent 05536d6 commit 3638d38
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ to your list. So, what to do? Create an object whose attributes' values can be o
That is why the `rules_map` input is available. It will accept a structure like that, an object whose
attribute values are lists of rules, where the lists themselves can be different types.

</summary>
</details>

The `rules_map` input takes an object.
- The attribute names (keys) of the object can be anything you want, but need to be known during `terraform plan`,
Expand Down
2 changes: 1 addition & 1 deletion README.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ usage: |-
That is why the `rules_map` input is available. It will accept a structure like that, an object whose
attribute values are lists of rules, where the lists themselves can be different types.
</summary>
</details>
The `rules_map` input takes an object.
- The attribute names (keys) of the object can be anything you want, but need to be known during `terraform plan`,
Expand Down
12 changes: 6 additions & 6 deletions exports/security_group_inputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,16 @@ variable "associated_security_group_ids" {
default = []
description = <<-EOT
A list of IDs of Security Groups to associate the created resource with, in addition to the created security group.
These security groups will not be modified and, if `create_security_group` is `false`, must provide all the required access.
EOT
These security groups will not be modified and, if `create_security_group` is `false`, must have rules providing the desired access.
EOT
}

variable "allowed_security_group_ids" {
type = list(string)
default = []
description = <<-EOT
A list of IDs of Security Groups to allow access to the security group created by this module.
EOT
EOT
}

variable "security_group_name" {
Expand All @@ -49,7 +49,7 @@ variable "security_group_name" {
The name to assign to the created security group. Must be unique within the VPC.
If not provided, will be derived from the `null-label.context` passed in.
If `create_before_destroy` is true, will be used as a name prefix.
EOT
EOT
}

variable "security_group_description" {
Expand Down Expand Up @@ -138,10 +138,10 @@ variable "vpc_id" {
variable "revoke_security_group_rules_on_delete" {
type = bool
default = false
description = <<-EOF
description = <<-EOT
Instruct Terraform to revoke all of the Security Group's attached ingress and egress rules before deleting
the security group itself. This is normally not needed.
EOF
EOT
}

variable "allow_all_egress" {
Expand Down

0 comments on commit 3638d38

Please sign in to comment.