Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the exported security_group_inputs.tf file to security-group-inputs.tf #30

Merged
merged 11 commits into from
Dec 29, 2021
Merged

Rename the exported security_group_inputs.tf file to security-group-inputs.tf #30

merged 11 commits into from
Dec 29, 2021

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Dec 28, 2021 •
edited
Loading

what

  • Rename the exported security_group_inputs.tf file to security-group-inputs.tf
  • Update GitHub workflows and LICENSE

why

  • Our naming convention is to use kebab-case for all files. Having a file in snake_case (after adding it to a repo) together with all the other files in kebab-case in the same repo does not look correct
  • Keep up to date

@aknysh aknysh added the patch A minor, backward compatible change label Dec 28, 2021
@aknysh aknysh self-assigned this Dec 28, 2021
@aknysh aknysh requested review from a team as code owners December 28, 2021 22:51
@aknysh
Copy link
Member Author

aknysh commented Dec 28, 2021

/test all

@aknysh
Copy link
Member Author

aknysh commented Dec 28, 2021

/test all

@aknysh
Copy link
Member Author

aknysh commented Dec 29, 2021

/test all

@aknysh
Copy link
Member Author

aknysh commented Dec 29, 2021

/test all

@aknysh
Copy link
Member Author

aknysh commented Dec 29, 2021

/test all

@aknysh
Copy link
Member Author

aknysh commented Dec 29, 2021

/test all

@aknysh
Copy link
Member Author

aknysh commented Dec 29, 2021

/test all

@aknysh
Copy link
Member Author

aknysh commented Dec 29, 2021

/test terratest

@aknysh
Copy link
Member Author

aknysh commented Dec 29, 2021

/test terratest

@aknysh
Copy link
Member Author

aknysh commented Dec 29, 2021

/test all

@aknysh aknysh merged commit ccaf794 into master Dec 29, 2021
@aknysh aknysh deleted the rename-exported-file branch December 29, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@Nuru Nuru Awaiting requested review from Nuru

@nitrocode nitrocode Awaiting requested review from nitrocode

@korenyoni korenyoni Awaiting requested review from korenyoni

Assignees

@aknysh aknysh

Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aknysh @osterman