Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle self = false, add warning about compact and sort #33

Merged
merged 1 commit into from
May 11, 2022
Merged

Conversation

Nuru
Copy link
Sponsor Contributor

@Nuru Nuru commented May 11, 2022

what

  • Handle self = false
  • Add warning about compact and sort

why

  • Setting self = false in a rule (meaning the rule does not apply to the security group it is being associated with) was causing an empty rule to be created and/or causing conflicts with other rule elements. Now it works like self = null works.
  • Explain some causes of the dreaded "Invalid for_each argument" error and what to do to fix it.

references

@Nuru Nuru added the bugfix Change that restores intended behavior label May 11, 2022
@Nuru Nuru requested review from aknysh and Benbentwo May 11, 2022 02:12
@Nuru Nuru requested review from a team as code owners May 11, 2022 02:12
@Nuru Nuru requested a review from milldr May 11, 2022 02:13
@Nuru
Copy link
Sponsor Contributor Author

Nuru commented May 11, 2022

/test all

@Nuru Nuru merged commit cad3268 into master May 11, 2022
@Nuru Nuru deleted the omit-empty branch May 11, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Change that restores intended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants