enabling using multiple ssh keys for one user in sftp module #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI @Gowiem ! |
Gowiem
requested changes
Aug 21, 2024
There was a problem hiding this comment.
@romga I believe I understand what you're getting at here and I like the direction, but since we're doing this enhancement, I want to do it right. Can you do the following for me:
- Update the
typeofsftp_usersto be a list ofobjectwith strict typing to support the multiple key use-case that you're enabling here. Please update the name of the key topublic_keysso it's clear that it's an array type. We'll issue this as a major version rev. - Can you please include code comments in your data manipulations to explain what you're doing and how those new locals are used?
Let me know if you have any questions -- Thank you!
|
hi @Gowiem ! I have made the changes you have asked for! Can you please review them? :) Thank you! |
|
Hi @Gowiem |
|
Hi @Gowiem I have pushed a new commit, can you please review now? :) Thank you! |
|
/terratest |
romga
force-pushed
the
feautre/enabling-using-multiple-ssh-keys
branch
from
7840524
to
461c561
Compare
|
Hi @Gowiem Thank you! |
|
/terratest |
|
/terratest |
|
/terratest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
*Enabling to add for one user multiple ssh keys
why
references
`closes #35