Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Update module github.com/cloudquery/plugin-sdk/v3 to v3.8.1 #172

Merged
merged 12 commits into from
Jun 1, 2023

Conversation

candiduslynx
Copy link
Contributor

@candiduslynx candiduslynx commented May 31, 2023

Extracted from #171

Structs reading is slow because of apache/arrow#35851
Fields copy is because of apache/arrow#35867

@candiduslynx candiduslynx changed the title fix(deps): Update module github.com/cloudquery/plugin-sdk/v3 to v3.7.0 fix(deps): Update module github.com/cloudquery/plugin-sdk/v3 to v3.8.1 Jun 1, 2023
@github-actions github-actions bot added fix and removed fix labels Jun 1, 2023
@candiduslynx candiduslynx marked this pull request as ready for review June 1, 2023 09:16
@github-actions github-actions bot added fix and removed fix labels Jun 1, 2023
@candiduslynx candiduslynx added the automerge Add to automerge PRs once requirements are met label Jun 1, 2023
@candiduslynx
Copy link
Contributor Author

@hermanschaaf @disq @erezrokah
I presume the written parquet data will now be different (maps are available, structs are now not strings, but structs).
Should it be a breaking change?

@candiduslynx candiduslynx removed the automerge Add to automerge PRs once requirements are met label Jun 1, 2023
@kodiakhq kodiakhq bot merged commit 01c789b into main Jun 1, 2023
@kodiakhq kodiakhq bot deleted the deps/sdk-3.7.0 branch June 1, 2023 09:18
@disq
Copy link
Member

disq commented Jun 1, 2023

@hermanschaaf @disq @erezrokah I presume the written parquet data will now be different (maps are available, structs are now not strings, but structs). Should it be a breaking change?

I think it's ok since we're moving very fast in the v3 migration

kodiakhq bot pushed a commit that referenced this pull request Jun 1, 2023
🤖 I have created a release *beep* *boop*
---


## [3.1.1](v3.1.0...v3.1.1) (2023-06-01)


### Bug Fixes

* **deps:** Update github.com/apache/arrow/go/v13 digest to cbc17a9 ([#174](#174)) ([554647d](554647d))
* **deps:** Update golang.org/x/exp digest to 2e198f4 ([#175](#175)) ([b107af6](b107af6))
* **deps:** Update google.golang.org/genproto digest to e85fd2c ([#176](#176)) ([704f63b](704f63b))
* **deps:** Update google.golang.org/genproto/googleapis/rpc digest to e85fd2c ([#178](#178)) ([fdffb53](fdffb53))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.6.5 ([#167](#167)) ([53886bc](53886bc))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.6.6 ([#169](#169)) ([4345834](4345834))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.6.7 ([#170](#170)) ([92cf875](92cf875))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.8.1 ([#172](#172)) ([01c789b](01c789b))
* **deps:** Update module github.com/mattn/go-isatty to v0.0.19 ([#177](#177)) ([8437644](8437644))
* **deps:** Update module github.com/stretchr/testify to v1.8.4 ([#179](#179)) ([bc5d374](bc5d374))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants