Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stacker & stacker_blueprints troposphere requirements out of sync #188

Closed
phobologic opened this issue Aug 4, 2016 · 3 comments
Closed

Comments

@phobologic
Copy link
Member

Right now, the required version of troposphere is different for stacker & stacker_blueprints:

stacker: troposphere>=1.22
stacker_blueprints: troposphere==1.7.0

The >= just caused issues with tests due to circleCI seemingly caching the image between runs, and it being stuck on 1.5.0, when PR #185 needed a feature from 1.6.0.

Not sure what the right thing to do here is. We could make them match and try to keep that in sync, though not sure that's the best way.

@mhahn any comments - you said you ran into issues with this.

@phobologic
Copy link
Member Author

For now I think we just need to update troposphere for stacker to match the version that it needs - ie: 1.6 in #185. Still not sure what the right thing is to do with both stacker & stacker_blueprints depending on it.

@mwildehahn
Copy link
Contributor

It seems reasonable to me to require that we use "compatible release" versions for both libraries since they're so connected: https://www.python.org/dev/peps/pep-0440/#compatible-release.

I was bit by just doing a blanket troposphere>=1.2 and then there was a backwards incompatible change somewhere in there.

I think doing troposphere~=1.7.0 in both libraries is the safest thing.

@mwildehahn
Copy link
Contributor

mwildehahn commented Aug 29, 2016

#201 and remind101/stacker_blueprints#30 address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants