Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8+ support #67

Closed
mxr576 opened this issue Sep 12, 2022 · 1 comment
Closed

PHP 8+ support #67

mxr576 opened this issue Sep 12, 2022 · 1 comment
Labels
Milestone

Comments

@mxr576
Copy link

mxr576 commented Sep 12, 2022

The following deprecation notices are generated when I run the latest release on PHP 8.1

php graph-composer-1.1.0.phar export ./
[12-Sep-2022 07:56:11 UTC] PHP Deprecated:  Return type of Symfony\Component\Console\Helper\HelperSet::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///mnt/files/local_mount/build/graph-composer-1.1.0.phar/vendor/symfony/console/Symfony/Component/Console/Helper/HelperSet.php on line 104

Deprecated: Return type of Symfony\Component\Console\Helper\HelperSet::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///mnt/files/local_mount/build/graph-composer-1.1.0.phar/vendor/symfony/console/Symfony/Component/Console/Helper/HelperSet.php on line 104
[12-Sep-2022 07:56:11 UTC] PHP Deprecated:  Return type of Fhaculty\Graph\Set\Vertices::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///mnt/files/local_mount/build/graph-composer-1.1.0.phar/vendor/clue/graph/src/Set/Vertices.php on line 414

Deprecated: Return type of Fhaculty\Graph\Set\Vertices::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///mnt/files/local_mount/build/graph-composer-1.1.0.phar/vendor/clue/graph/src/Set/Vertices.php on line 414
[12-Sep-2022 07:56:11 UTC] PHP Deprecated:  Return type of Fhaculty\Graph\Set\Vertices::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///mnt/files/local_mount/build/graph-composer-1.1.0.phar/vendor/clue/graph/src/Set/Vertices.php on line 451

Deprecated: Return type of Fhaculty\Graph\Set\Vertices::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///mnt/files/local_mount/build/graph-composer-1.1.0.phar/vendor/clue/graph/src/Set/Vertices.php on line 451
[12-Sep-2022 07:56:11 UTC] PHP Deprecated:  Return type of Fhaculty\Graph\Set\Edges::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///mnt/files/local_mount/build/graph-composer-1.1.0.phar/vendor/clue/graph/src/Set/Edges.php on line 386

Deprecated: Return type of Fhaculty\Graph\Set\Edges::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///mnt/files/local_mount/build/graph-composer-1.1.0.phar/vendor/clue/graph/src/Set/Edges.php on line 386
[12-Sep-2022 07:56:11 UTC] PHP Deprecated:  Return type of Fhaculty\Graph\Set\Edges::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///mnt/files/local_mount/build/graph-composer-1.1.0.phar/vendor/clue/graph/src/Set/Edges.php on line 412

Deprecated: Return type of Fhaculty\Graph\Set\Edges::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///mnt/files/local_mount/build/graph-composer-1.1.0.phar/vendor/clue/graph/src/Set/Edges.php on line 412
@SimonFrings
Copy link
Contributor

SimonFrings commented Sep 12, 2022

Hey @mxr576, thanks for bringing this up 👍

This should already be fixed for the upcoming v1.2.0. I invite you to run this with the current state of the project, there should be no more deprecation notices (#62 and #63).

I don't know when v1.2.0 will go live, we're currently involved in a lot of other tasks that need our attention. If you need things to speed up in here, consider supporting the project and we'll take a look ;)

@clue clue added this to the v1.2.0 milestone Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants