You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently don't have a way for the pppm parameters to be set for the long and short range charge interactions. We could add this as a prameter to System but I think it would be better if its available/editable in the Simulation class. First we need to determine if this is something that can be modified once the hoomd forces are created.
The text was updated successfully, but these errors were encountered:
The order and resolution parameters can be changed as long as the simulation hasn't run, but there is this warning message in the hoomd docs:
make_pppm_coulomb_forces sets all parameters for the returned Force objects given the input resolution and order. Do not change the parameters of the returned objects directly.
So, I don't think changing these after the fact will be a good idea, if the other parameters determined from them aren't updated.
We could add parameters for these that are passed along to GMSO so they are set correctly initially. However, we're kind of running into the issue of having all these parameters in System.__init__ that are only ever used by _apply_forcefield. This isn't a great workflow IMO, especially since System can be used without a forcefield
I think we should revisit the idea of making _apply_forcefield public, and moving these parameters there. This requires the user to call it and define all of these parameters there instead of in System.__init__
We currently don't have a way for the pppm parameters to be set for the long and short range charge interactions. We could add this as a prameter to
System
but I think it would be better if its available/editable in theSimulation
class. First we need to determine if this is something that can be modified once the hoomd forces are created.The text was updated successfully, but these errors were encountered: