Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move redundant get-summary function implementations into common ns #36

Open
oubiwann opened this issue Dec 13, 2017 · 0 comments
Open
Labels

Comments

@oubiwann
Copy link
Member

  • Option 1: cmr.dev.env.manager.components.common
  • Option 2: cmr.dev.env.manager.components.checks.common

Leaning towards the first one, since:

  1. the ns's that are using it will be in cmr.dev.env.manager.components and cmr.dev.env.manager.components.dem
  2. the ns cmr.dev.env.manager.components.checks health pulls in ns's from cmr.dev.env.manager.components and cmr.dev.env.manager.components.dem ... and we wouldn't want to cross the streams ...
@oubiwann oubiwann added the task label Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant