Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Destruction of uninitialized Value in FillPredicateArray #1363

Open
Zeninma opened this issue May 13, 2018 · 0 comments
Open

Destruction of uninitialized Value in FillPredicateArray #1363

Zeninma opened this issue May 13, 2018 · 0 comments

Comments

@Zeninma
Copy link
Contributor

Zeninma commented May 13, 2018

Inside peloton/src/codegen/runtime_functions.cpp, void RuntimeFunctions::FillPredicateArray assigns (*parsed_predicates)[i].predicate_value to predicate_array[i].predicate_value. However, predicate_array[i].predicate_value has never been initialized. In Table::GenerateScan, it only gets allocated a block of memory. Hence, during the assignment an uninitialized Value will be destructred and cause a valgrind error Conditional jump or move depends on uninitialised value(s) at the destructor's switch statement .
We solved this problem in our PR(#1339) by avoid using predicate_array and calling RuntimeFunctions:: FillPredicateArray.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant