Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SANDBOX PROJECT ONBOARDING] External Secrets Operator #211

Closed
29 tasks done
amye opened this issue Jul 26, 2022 · 30 comments
Closed
29 tasks done

[SANDBOX PROJECT ONBOARDING] External Secrets Operator #211

amye opened this issue Jul 26, 2022 · 30 comments

Comments

@amye
Copy link

amye commented Jul 26, 2022

Welcome to CNCF Project Onboarding!
This is an issue created to help onboard your project into the CNCF after the TOC has voted to accept your project.
We would like to complete onboarding within one month of acceptance.

From the project side, please ensure that you:

Things that CNCF will need from the project:

  • Provide emails for the maintainers added to https://maintainers.cncf.io in order to get access to the maintainers mailing list and ServiceDesk
  • Trademarks: transfer any trademark and logo mark assets over to the LF - https://github.com/cncf/foundation/tree/master/agreements has agreements
  • GitHub: ensure 'thelinuxfoundation' and 'caniszczyk' are added as initial org owners, this helps us make sure we have continuity of GH ownership
  • GitHub: ensure DCO or CLA are enabled for all GitHub repositories of the project
  • GitHub: ensure that hat the CNCF Code of Conduct (or your adopted version of it) are explicitly referenced at the project's README on GitHub
  • Website: ensure LF footer is there and website guidelines followed (if your project doesn't have a dedicated website, please adopt those guidelines to the README file of your project on GitHub).
  • Website: Analytics transferred to projects@cncf.io
  • CII: Start on a CII best practices badge https://bestpractices.coreinfrastructure.org/en

Things that the CNCF will do or help the project to do:

@moolen
Copy link

moolen commented Jul 27, 2022

Hey there! We're thrilled about this! 🎉 🥳
We've created the above 👆 linked issue to assign/track the work on our end. I'm sure there will be questions, we'll post them here.

Do you want us to post a proof of something when we've finished some piece of work: E.g. a screenshot of adding the LF footer to the website or a screenshot of GitHub Org ownership?

@amye
Copy link
Author

amye commented Jul 27, 2022

Marking it off in comments is completely fine, and thank you!

@gusfcarvalho
Copy link

gusfcarvalho commented Jul 27, 2022

Hey all! Some questions came up to this one:

[ ] Website: Analytics transferred to projects@cncf.io

Is it enough to add projects@cncf.io to owner in our google analytics, or does transfer mean a different thing here? If it means a different thing, can anyone point us to the direction on how to? 😄

@amye
Copy link
Author

amye commented Jul 27, 2022

Try the first one and I'll check it for you

@gusfcarvalho
Copy link

gusfcarvalho commented Jul 28, 2022

Try the first one and I'll check it for you

Thanks for your help! Just added to our analytics!

@knelasevero
Copy link

Another Question, we have an Opencollective sponsoring page, with individual contributors and Organisation contributors. Is there a problem with keeping it? Is there any action items related to that that we are not aware of?

@knelasevero
Copy link

Regarding the slack channel, we wanted to check if we could get admin rights in the channel that we already have in K8S slack space? We have a lot of movement there, I think we would confuse some users migrating to a new space.

@knelasevero
Copy link

knelasevero commented Jul 28, 2022

About the domain, we have it in Google Domains. Is it enough to add that email as owner? Or do we have to go through the actual transfer to the other service?

@knelasevero
Copy link

knelasevero commented Aug 1, 2022

Emails from maintainers :)

Lucas Severo Alves, knelasevero, lucassalves65@gmail.com
Moritz johner, moolen, beller.moritz@googlemail.com
Gustavo Fernandes de Carvalho, gusfcarvalho, gusfcarvalho@gmail.com

@gusfcarvalho @moolen do you think we should add more emails here? We have more people as emeritus approvers, etc.

@lukaszgryglicki
Copy link
Member

DevStats page added.

@moolen
Copy link

moolen commented Aug 2, 2022

do you think we should add more emails here?

Don't think so, we're good!

@gusfcarvalho
Copy link

Hello! some questions regarding the trademark transfer (non registered):
Paragraph 3.a As Container Solutions, are we allowed to still refer to eso logo? What are the rules for that? (e.g. running meetups, social media content, blog posts)

ESO is a joint community project. In so, Container Solutions does not own any top level domain bound to the ESO Logo. How would Paragraph 3.b apply in this case? Do we need extra sign offs from the other people/organizations that own these resouurces?

Is there any legal team we can forward our questions to, either on a call or via email?

@amye
Copy link
Author

amye commented Aug 8, 2022

Short answer: https://www.linuxfoundation.org/trademarks/
Longer answer: The project is still allowed to use the logo, we at CNCF/LF just hold the logo as part of the neutral home for IP.
If you don't have a domain, that's fine.

@gusfcarvalho
Copy link

gusfcarvalho commented Aug 9, 2022

Short answer: https://www.linuxfoundation.org/trademarks/ Longer answer: The project is still allowed to use the logo, we at CNCF/LF just hold the logo as part of the neutral home for IP. If you don't have a domain, that's fine.

Thanks for the answer, but something is still not clear! the project does have a domain, but it is not owned by the organization that owns the logos (since this project was really community-driven ever since from the beginning, different people got responsible for different things). The domain is owned personally by another maintainer and would be donated anyways. The question would be: do we need the maintainer that owns the domain to also sign a separate document? Or just the one from Container Solutions (the org owning the logos) would be enough?

Sorry for these questions - they are been asked by our legal teams here, and I am not that versed on the theme, unfortunately 😅

@gusfcarvalho
Copy link

Hello!

Regarding the ongoing process for onboarding, there are only two points that we remaing to do, and we still some help on them:

  1. the first one is regarding the domain transfer to the CNCF. We currently have our domain in Google Domains, and we would like to know if it would be enough to add owner permissions there, or if a domain transfer would really be necessary

  2. The second one is more tricky, it is regarding about transfering logo assets over to the LF. The logos for the project are from the company where I work at (Container Solutions), but the domain itself is from another maintainer which is not part of Container Solutions (this project was really built up from the community, so multiple people own different things). When I showed the non-trademark agreement to our legal team, they became a little bit uncertain about clause 3.b - basically because since Container Solutions does not own the domain where the logo is applied, we as a company would not be able to conform to this clause. What I thought about doing is to have the maintainer sign that documentation together with Container Solutions (which would cause a change to the agreement as written), so I wanted to see if that would be acceptable for CNCF.

Any help would be appreciated!

@amye
Copy link
Author

amye commented Aug 29, 2022

Hello!

Regarding the ongoing process for onboarding, there are only two points that we remaing to do, and we still some help on them:

  1. the first one is regarding the domain transfer to the CNCF. We currently have our domain in Google Domains, and we would like to know if it would be enough to add owner permissions there, or if a domain transfer would really be necessary

We'll need to have that transferred, it's part of the assets for the project overall. https://jira.linuxfoundation.org/plugins/servlet/theme/portal/2/create/63 is the best place to start.

  1. The second one is more tricky, it is regarding about transfering logo assets over to the LF. The logos for the project are from the company where I work at (Container Solutions), but the domain itself is from another maintainer which is not part of Container Solutions (this project was really built up from the community, so multiple people own different things). When I showed the non-trademark agreement to our legal team, they became a little bit uncertain about clause 3.b - basically because since Container Solutions does not own the domain where the logo is applied, we as a company would not be able to conform to this clause. What I thought about doing is to have the maintainer sign that documentation together with Container Solutions (which would cause a change to the agreement as written), so I wanted to see if that would be acceptable for CNCF.

What we've done in the past is have the group of maintainers who contributed the project over, is that the group that's listed in your PR for maintainers.cncf.io?

Any help would be appreciated!

@gusfcarvalho
Copy link

We internally arranged a transfer of the domain to Container Solutions, so our legal team was comfortable with signing the agreement -> Assignment - Signed by CS.pdf. Is it enough to upload it here?

@amye
Copy link
Author

amye commented Sep 8, 2022

We will need to review this, please send this to project-onboarding@cncf.io

@gusfcarvalho
Copy link

gusfcarvalho commented Sep 12, 2022

We will need to review this, please send this to project-onboarding@cncf.io

Done!

We're also done with these following items:

We didn't yet receive any invitation to the maintainers.cncf.io, so probably this still needs to be added. The maintainer emails are:

@amye
Copy link
Author

amye commented Sep 12, 2022

Not seeing a domain transfer or Github, can you check for me?
Invites have been sent to maintainers lists and Service desk.

@knelasevero
Copy link

knelasevero commented Sep 12, 2022

Domain transfer: https://jira.linuxfoundation.org/plugins/servlet/theme/portal/2/IT-24483 :)

What specifically about github?

  • GitHub: ensure DCO or CLA are enabled for all GitHub repositories of the project

This is done and verifiable at any PR: external-secrets/external-secrets#1537

image

  • GitHub: ensure 'thelinuxfoundation' and 'caniszczyk' are added as initial org owners, this helps us make sure we have continuity of GH ownership

Oh, caniszczyk is added, checking now it seems linuxfoundation recevied the invitation but that account let it expire:

image

image

We just re-sent to thelinuxfoundation account.

@amye
Copy link
Author

amye commented Sep 12, 2022

Taken care of!
Do you want a space on community.cncf.io?

@gusfcarvalho
Copy link

Taken care of!
Do you want a space on community.cncf.io?

Yes please 😁

@amye
Copy link
Author

amye commented Nov 7, 2022

Taken care of!
Do you want a space on community.cncf.io?

Yes please 😁

https://community.cncf.io/external-secrets-operator-community/ is live, who should get access?

@knelasevero
Copy link

@amye

Lucas Severo Alves, knelasevero, lucassalves65@gmail.com
Moritz johner, moolen, beller.moritz@googlemail.com
Gustavo Fernandes de Carvalho, gusfcarvalho, gusfcarvalho@gmail.com

Us 3 I think. @moolen @gusfcarvalho anybody else?

@moolen
Copy link

moolen commented Dec 13, 2022

hey @amye, do you need anything else from us?

@amye
Copy link
Author

amye commented Dec 14, 2022

The FOSSA piece is the only one left!

@moolen
Copy link

moolen commented Dec 14, 2022

Thank you!
I've added FOSSA integration and identified a couple of issues with usage of MPL-2.0 (hashicorp libs). I'm tracking a investigation here: external-secrets/external-secrets#1820. I'm probably gonna open an issue in cncf/foundation to request a exemption for the remaining two libraries.

moolen referenced this issue in moolen/landscape Dec 21, 2022
see: https://github.com/cncf/toc/issues/882#issuecomment-1202324717

Signed-off-by: Moritz Johner <moolen@users.noreply.github.com>
@moolen
Copy link

moolen commented Dec 21, 2022

There should be nothing left to do, i think this issue can be closed.

caniszczyk referenced this issue in cncf/landscape Dec 21, 2022
see: https://github.com/cncf/toc/issues/882#issuecomment-1202324717

Signed-off-by: Moritz Johner <moolen@users.noreply.github.com>

Signed-off-by: Moritz Johner <moolen@users.noreply.github.com>
@amye amye closed this as completed Dec 21, 2022
@amye
Copy link
Author

amye commented Dec 21, 2022

Welcome onboard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants