kvserver/liveness: liveness storage sends batch requests without admission header #130014
Labels
A-admission-control
branch-master
Failures and bugs on the master branch.
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
T-kv
KV Team
Describe the problem
At least one source of the reports found in #112680 is likely the following to uses of the Get and Scan methods on
kv.DB
in liveness.Storage:cockroach/pkg/kv/kvserver/liveness/storage.go
Line 73 in a1cfb1b
cockroach/pkg/kv/kvserver/liveness/storage.go
Line 201 in a1cfb1b
Replacing these two uses a db.Txn() avoids the warning in a good number of the reproductions I've seen locally. We likely don't want a Txn here though, so we'll want to use a different API that allows us to pass in an admission header.
Jira issue: CRDB-41842
The text was updated successfully, but these errors were encountered: