Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver/liveness: liveness storage sends batch requests without admission header #130014

Open
stevendanna opened this issue Sep 3, 2024 · 2 comments
Assignees
Labels
A-admission-control branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv KV Team

Comments

@stevendanna
Copy link
Collaborator

stevendanna commented Sep 3, 2024

Describe the problem

At least one source of the reports found in #112680 is likely the following to uses of the Get and Scan methods onkv.DB in liveness.Storage:

record, err := ls.db.Get(ctx, keys.NodeLivenessKey(nodeID))

kvs, err := ls.db.Scan(ctx, keys.NodeLivenessPrefix, keys.NodeLivenessKeyMax, 0)

Replacing these two uses a db.Txn() avoids the warning in a good number of the reproductions I've seen locally. We likely don't want a Txn here though, so we'll want to use a different API that allows us to pass in an admission header.

Jira issue: CRDB-41842

@stevendanna stevendanna added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Sep 3, 2024
Copy link

blathers-crl bot commented Sep 3, 2024

Hi @stevendanna, please add branch-* labels to identify which branch(es) this C-bug affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@stevendanna stevendanna added branch-master Failures and bugs on the master branch. T-admission-control Admission Control labels Sep 3, 2024
@aadityasondhi
Copy link
Collaborator

Thanks for reporting this and finding the source!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-admission-control branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv KV Team
Projects
None yet
Development

No branches or pull requests

2 participants