You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #19650 has added planning support for FOR UPDATE, propagating the flag throughout the data source hierarchy.
However the planning changes in that PR were not complemented by tests that would check the flag indeed propagates to those table scans involved in the SELECT clause, and not to other tables.
This should be tested via EXPLAIN.
Hence the following suggestion:
store the bit in the scanNode (even though the intents are not laid yet)
have the plan walker (sql/walk.go) reveal that bit
add EXPLAIN tests that show what happens for 1) simple queries 2) UPDATE/DELETE etc 3) with a join 4) with a join where only a subquery specifies the flag, e.g. select ... from (select ... for update), (select ...)
The text was updated successfully, but these errors were encountered:
PR #19650 has added planning support for FOR UPDATE, propagating the flag throughout the data source hierarchy.
However the planning changes in that PR were not complemented by tests that would check the flag indeed propagates to those table scans involved in the SELECT clause, and not to other tables.
This should be tested via EXPLAIN.
Hence the following suggestion:
sql/walk.go
) reveal that bitselect ... from (select ... for update), (select ...)
The text was updated successfully, but these errors were encountered: