Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: avoid non-MVCC operations #70429

Closed
erikgrinaker opened this issue Sep 20, 2021 · 2 comments
Closed

*: avoid non-MVCC operations #70429

erikgrinaker opened this issue Sep 20, 2021 · 2 comments
Assignees
Labels
A-disaster-recovery A-kv-replication Relating to Raft, consensus, and coordination. A-schema-changes C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Sep 20, 2021

⚠️ This tracking issue is largely superceded by Jira epic CRDB-2624 ⚠️

As described in #69380, we want to replace use of non-MVCC commands such as ClearRange, RevertRange, and AddSSTable with MVCC-compliant alternatives, as these violate invariants that other components rely on. This involves:

MVCC range deletion tombstones

AddSSTable at current timestamp

Epic CRDB-2624

Jira issue: CRDB-10072

@blathers-crl
Copy link

blathers-crl bot commented Jun 3, 2022

cc @cockroachdb/replication

@erikgrinaker
Copy link
Contributor Author

All significant bulk operations are now MVCC-compliant for 22.2. The exceptions are:

  • Tenant replication: can write MVCC history and revert it, into offline tenants.
  • Tenant GC: uses ClearRange, to allow immediate restore into same keyspace (e.g. for backup restoration).
  • Tenant restores: backfills MVCC history, into offline tenants.

These exceptions don't pose a major issue, since C2C replication is always per tenant, and their logical clusters are offline while the operations are performed (for all intents and purposes, these are new tenants).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery A-kv-replication Relating to Raft, consensus, and coordination. A-schema-changes C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants