Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: break out integration-style tests #78237

Closed
tbg opened this issue Mar 22, 2022 · 2 comments
Closed

kvserver: break out integration-style tests #78237

tbg opened this issue Mar 22, 2022 · 2 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale

Comments

@tbg
Copy link
Member

tbg commented Mar 22, 2022

We would like to be able to move the kvserver_test tests into subpackages to
start trimming down the kvserver package as a whole. This projected to allow
reducing CI cycle time and, over time, will allow specialized test suites to
live in subpackages (for example, integration tests related to data placement).

The main obstacle is that kvserver_test tests reach into internals of
kvserver using the helpers_test files which add additional accessors, etc.

The proposal is to move any such accessors behind testing interfaces on their
receivers, i.e. (*Replica).Testing().DoSomething(), and then to move all
kvserver_test tests into a subpackage kvinttest (name TBD).

Internal discussion

Jira issue: CRDB-14029

@blathers-crl

This comment was marked as resolved.

@blathers-crl blathers-crl bot added the T-kv KV Team label Mar 22, 2022
@tbg tbg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) and removed T-kv KV Team labels Mar 22, 2022
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale
Projects
No open projects
Archived in project
Development

No branches or pull requests

1 participant