Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove multi-tenancy function from generated function doc #84756

Closed
ghost opened this issue Jul 20, 2022 · 2 comments · Fixed by #87132
Closed

Remove multi-tenancy function from generated function doc #84756

ghost opened this issue Jul 20, 2022 · 2 comments · Fixed by #87132
Labels
A-cdc Change Data Capture A-docs A-sql-builtins SQL built-in functions and semantics thereof. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@ghost
Copy link

ghost commented Jul 20, 2022 •
edited by ghost
Loading

Describe the problem

We don't document multi-tenancy features in the public docs: https://www.cockroachlabs.com/docs/stable/functions-and-operators.html#multi-tenancy-functions. Either remove the function crdb_internal.sql_liveness_is_alive added in #51087 or recategorize it. There's also a typo in the definition:

Checks is given sqlliveness session id is not expired -> Checks if given sqlliveness session id is not expired

Jira issue: CRDB-17846
@ghost ghost added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-cdc Change Data Capture labels Jul 20, 2022
@blathers-crl blathers-crl bot added the T-cdc label Jul 20, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jul 20, 2022

cc @cockroachdb/cdc

@knz
Copy link
Contributor

knz commented Jul 28, 2022

cc @rafiss for triage

@knz knz added A-docs A-sql-builtins SQL built-in functions and semantics thereof. and removed T-cdc labels Jul 28, 2022
@rafiss rafiss mentioned this issue Aug 1, 2022
Merged
@rafiss rafiss mentioned this issue Aug 30, 2022
Merged
@craig craig bot closed this as completed in fde7aaf Sep 1, 2022
This was referenced Sep 6, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cdc Change Data Capture A-docs A-sql-builtins SQL built-in functions and semantics thereof. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

builtins: hide multitenancy functions from docs and fix categories rafiss/cockroach
1 participant
@knz