Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: remove EnablePebbleFormatVersionBlockProperties version gate #86150

Closed
nicktrav opened this issue Aug 15, 2022 · 0 comments
Closed

storage: remove EnablePebbleFormatVersionBlockProperties version gate #86150

nicktrav opened this issue Aug 15, 2022 · 0 comments
Assignees
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team

Comments

@nicktrav
Copy link
Collaborator

nicktrav commented Aug 15, 2022

We want to remove the old version gates before 22.2 is released (see #80663).

One of these gates is EnablePebbleFormatVersionBlockProperties. This version gate is currently used to gate how an "external" sstable is written. We'll need to take this into account when removing. I believe it to be true that a cluster running 22.2 will be at a sufficiently high enough format major version to not require the version check, though we should validate this assumption first.

Jira issue: CRDB-18601

@nicktrav nicktrav added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-storage Relating to our storage engine (Pebble) on-disk storage. T-storage Storage Team labels Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team
Projects
None yet
Development

No branches or pull requests

2 participants