diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 7058f9852a48..224a20066374 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -38,45 +38,45 @@ /pkg/sql/show_create*.go @cockroachdb/sql-syntax-prs /pkg/sql/types/ @cockroachdb/sql-syntax-prs -/pkg/sql/crdb_internal.go @cockroachdb/sql-sessions -/pkg/sql/pg_catalog.go @cockroachdb/sql-sessions -/pkg/sql/pgwire/ @cockroachdb/sql-sessions -/pkg/sql/sem/builtins/ @cockroachdb/sql-sessions -/pkg/sql/vtable/ @cockroachdb/sql-sessions +/pkg/sql/crdb_internal.go @cockroachdb/sql-foundations +/pkg/sql/pg_catalog.go @cockroachdb/sql-foundations +/pkg/sql/pgwire/ @cockroachdb/sql-foundations +/pkg/sql/sem/builtins/ @cockroachdb/sql-foundations +/pkg/sql/vtable/ @cockroachdb/sql-foundations -/pkg/sql/sessiondata/ @cockroachdb/sql-sessions -/pkg/sql/tests/rsg_test.go @cockroachdb/sql-sessions -/pkg/sql/ttl @cockroachdb/sql-sessions +/pkg/sql/sessiondata/ @cockroachdb/sql-foundations +/pkg/sql/tests/rsg_test.go @cockroachdb/sql-foundations +/pkg/sql/ttl @cockroachdb/sql-foundations -/pkg/ccl/schemachangerccl/ @cockroachdb/sql-schema -/pkg/sql/catalog/ @cockroachdb/sql-schema +/pkg/ccl/schemachangerccl/ @cockroachdb/sql-foundations +/pkg/sql/catalog/ @cockroachdb/sql-foundations /pkg/sql/catalog/multiregion @cockroachdb/multiregion -/pkg/sql/doctor/ @cockroachdb/sql-schema -/pkg/sql/gcjob/ @cockroachdb/sql-schema -/pkg/sql/gcjob_test/ @cockroachdb/sql-schema -/pkg/sql/privilege/ @cockroachdb/sql-schema -/pkg/sql/schemachange/ @cockroachdb/sql-schema -/pkg/sql/schemachanger/ @cockroachdb/sql-schema -/pkg/sql/alter*.go @cockroachdb/sql-schema -/pkg/sql/backfill*.go @cockroachdb/sql-schema -/pkg/sql/create*.go @cockroachdb/sql-schema -/pkg/sql/database*.go @cockroachdb/sql-schema -/pkg/sql/drop*.go @cockroachdb/sql-schema -/pkg/sql/grant*.go @cockroachdb/sql-schema -/pkg/sql/rename*.go @cockroachdb/sql-schema -/pkg/sql/revoke*.go @cockroachdb/sql-schema -/pkg/sql/schema*.go @cockroachdb/sql-schema -/pkg/sql/zone*.go @cockroachdb/sql-schema +/pkg/sql/doctor/ @cockroachdb/sql-foundations +/pkg/sql/gcjob/ @cockroachdb/sql-foundations +/pkg/sql/gcjob_test/ @cockroachdb/sql-foundations +/pkg/sql/privilege/ @cockroachdb/sql-foundations +/pkg/sql/schemachange/ @cockroachdb/sql-foundations +/pkg/sql/schemachanger/ @cockroachdb/sql-foundations +/pkg/sql/alter*.go @cockroachdb/sql-foundations +/pkg/sql/backfill*.go @cockroachdb/sql-foundations +/pkg/sql/create*.go @cockroachdb/sql-foundations +/pkg/sql/database*.go @cockroachdb/sql-foundations +/pkg/sql/drop*.go @cockroachdb/sql-foundations +/pkg/sql/grant*.go @cockroachdb/sql-foundations +/pkg/sql/rename*.go @cockroachdb/sql-foundations +/pkg/sql/revoke*.go @cockroachdb/sql-foundations +/pkg/sql/schema*.go @cockroachdb/sql-foundations +/pkg/sql/zone*.go @cockroachdb/sql-foundations /pkg/cli/ @cockroachdb/cli-prs # last-rule-wins so bulk i/o takes userfile.go even though cli-prs takes pkg/cli /pkg/cli/userfile.go @cockroachdb/disaster-recovery -/pkg/cli/demo*.go @cockroachdb/cli-prs @cockroachdb/sql-sessions @cockroachdb/server-prs +/pkg/cli/demo*.go @cockroachdb/cli-prs @cockroachdb/sql-foundations @cockroachdb/server-prs /pkg/cli/debug*.go @cockroachdb/cli-prs @cockroachdb/kv-prs /pkg/cli/debug_job_trace*.go @cockroachdb/disaster-recovery -/pkg/cli/doctor*.go @cockroachdb/cli-prs @cockroachdb/sql-schema +/pkg/cli/doctor*.go @cockroachdb/cli-prs @cockroachdb/sql-foundations /pkg/cli/import_test.go @cockroachdb/cli-prs @cockroachdb/disaster-recovery -/pkg/cli/sql*.go @cockroachdb/cli-prs @cockroachdb/sql-sessions +/pkg/cli/sql*.go @cockroachdb/cli-prs @cockroachdb/sql-foundations /pkg/cli/start*.go @cockroachdb/cli-prs @cockroachdb/server-prs /pkg/cli/mt_proxy.go @cockroachdb/sqlproxy-prs @cockroachdb/server-prs /pkg/cli/mt_start_sql.go @cockroachdb/sqlproxy-prs @cockroachdb/server-prs @@ -120,10 +120,10 @@ /pkg/gen/ @cockroachdb/dev-inf -/pkg/acceptance/ @cockroachdb/sql-sessions +/pkg/acceptance/ @cockroachdb/sql-foundations /pkg/base/ @cockroachdb/server-prs /pkg/bench/ @cockroachdb/sql-queries-noreview -/pkg/bench/rttanalysis @cockroachdb/sql-schema +/pkg/bench/rttanalysis @cockroachdb/sql-foundations /pkg/blobs/ @cockroachdb/disaster-recovery /pkg/build/ @cockroachdb/dev-inf /pkg/ccl/baseccl/ @cockroachdb/cli-prs @@ -138,35 +138,35 @@ /pkg/ccl/multiregionccl/ @cockroachdb/multiregion /pkg/ccl/multitenantccl/ @cockroachdb/unowned /pkg/ccl/oidcccl/ @cockroachdb/server-prs -/pkg/ccl/partitionccl/ @cockroachdb/sql-schema @cockroachdb/multiregion +/pkg/ccl/partitionccl/ @cockroachdb/sql-foundations @cockroachdb/multiregion /pkg/ccl/serverccl/ @cockroachdb/server-prs /pkg/ccl/serverccl/statusccl @cockroachdb/sql-observability /pkg/ccl/telemetryccl/ @cockroachdb/obs-inf-prs /pkg/ccl/testccl/sqlccl/ @cockroachdb/sql-queries -/pkg/ccl/testccl/workload/schemachange/ @cockroachdb/sql-schema +/pkg/ccl/testccl/workload/schemachange/ @cockroachdb/sql-foundations /pkg/ccl/testutilsccl/ @cockroachdb/test-eng-noreview /pkg/ccl/utilccl/ @cockroachdb/server-prs -/pkg/ccl/workloadccl/ @cockroachdb/sql-sessions-noreview -/pkg/ccl/benchccl/rttanalysisccl/ @cockroachdb/sql-schema +/pkg/ccl/workloadccl/ @cockroachdb/sql-foundations-noreview +/pkg/ccl/benchccl/rttanalysisccl/ @cockroachdb/sql-foundations /pkg/clusterversion/ @cockroachdb/kv-prs-noreview /pkg/cmd/allocsim/ @cockroachdb/kv-prs /pkg/cmd/bazci/ @cockroachdb/dev-inf /pkg/cmd/cmdutil/ @cockroachdb/dev-inf -/pkg/cmd/cmp-protocol/ @cockroachdb/sql-sessions -/pkg/cmd/cmp-sql/ @cockroachdb/sql-sessions -/pkg/cmd/cmpconn/ @cockroachdb/sql-sessions +/pkg/cmd/cmp-protocol/ @cockroachdb/sql-foundations +/pkg/cmd/cmp-sql/ @cockroachdb/sql-foundations +/pkg/cmd/cmpconn/ @cockroachdb/sql-foundations /pkg/cmd/cockroach/ @cockroachdb/cli-prs /pkg/cmd/cockroach-oss/ @cockroachdb/cli-prs /pkg/cmd/cockroach-short/ @cockroachdb/cli-prs /pkg/cmd/compile-build/ @cockroachdb/dev-inf -/pkg/cmd/cr2pg/ @cockroachdb/sql-sessions +/pkg/cmd/cr2pg/ @cockroachdb/sql-foundations /pkg/cmd/dev/ @cockroachdb/dev-inf /pkg/cmd/docgen/ @cockroachdb/docs /pkg/cmd/docs-issue-generation/ @cockroachdb/dev-inf /pkg/cmd/fuzz/ @cockroachdb/test-eng -/pkg/cmd/generate-binary/ @cockroachdb/sql-sessions +/pkg/cmd/generate-binary/ @cockroachdb/sql-foundations /pkg/cmd/generate-distdir/ @cockroachdb/dev-inf -/pkg/cmd/generate-metadata-tables/ @cockroachdb/sql-sessions +/pkg/cmd/generate-metadata-tables/ @cockroachdb/sql-foundations /pkg/cmd/generate-spatial-ref-sys/ @cockroachdb/geospatial /pkg/cmd/generate-test-suites/ @cockroachdb/dev-inf /pkg/cmd/generate-staticcheck/ @cockroachdb/dev-inf @@ -196,7 +196,7 @@ /pkg/cmd/roachtest/tests @cockroachdb/test-eng-noreview /pkg/cmd/roachvet/ @cockroachdb/dev-inf /pkg/cmd/skip-test/ @cockroachdb/test-eng -/pkg/cmd/skiperrs/ @cockroachdb/sql-sessions +/pkg/cmd/skiperrs/ @cockroachdb/sql-foundations /pkg/cmd/skipped-tests/ @cockroachdb/test-eng /pkg/cmd/smithcmp/ @cockroachdb/sql-queries /pkg/cmd/smithtest/ @cockroachdb/sql-queries @@ -205,11 +205,11 @@ /pkg/cmd/uptodate/ @cockroachdb/dev-inf /pkg/cmd/urlcheck/ @cockroachdb/docs /pkg/cmd/whoownsit/ @cockroachdb/test-eng -/pkg/cmd/workload/ @cockroachdb/sql-sessions-noreview +/pkg/cmd/workload/ @cockroachdb/sql-foundations-noreview /pkg/cmd/wraprules/ @cockroachdb/obs-inf-prs-noreview /pkg/cmd/zerosum/ @cockroachdb/kv-noreview /pkg/col/ @cockroachdb/sql-queries -/pkg/compose/ @cockroachdb/sql-sessions +/pkg/compose/ @cockroachdb/sql-foundations /pkg/config/ @cockroachdb/server-prs /pkg/docs/ @cockroachdb/docs /pkg/featureflag/ @cockroachdb/cli-prs-noreview @@ -225,7 +225,7 @@ /pkg/keysbase/ @cockroachdb/kv-prs # Don't ping KV on updates to reserved descriptor IDs and such. /pkg/keys/constants.go @cockroachdb/kv-prs-noreview -/pkg/migration/ @cockroachdb/kv-prs-noreview @cockroachdb/sql-schema +/pkg/migration/ @cockroachdb/kv-prs-noreview @cockroachdb/sql-foundations /pkg/multitenant @cockroachdb/unowned /pkg/release/ @cockroachdb/dev-inf /pkg/roachpb/.gitattributes @cockroachdb/dev-inf @@ -260,7 +260,7 @@ /pkg/security/ @cockroachdb/server-prs @cockroachdb/prodsec /pkg/settings/ @cockroachdb/server-prs /pkg/spanconfig/ @cockroachdb/kv-prs -/pkg/startupmigrations/ @cockroachdb/server-prs @cockroachdb/sql-schema +/pkg/startupmigrations/ @cockroachdb/server-prs @cockroachdb/sql-foundations /pkg/streaming/ @cockroachdb/disaster-recovery /pkg/testutils/ @cockroachdb/test-eng-noreview /pkg/testutils/reduce/ @cockroachdb/sql-queries @@ -272,7 +272,7 @@ /pkg/util/metric @cockroachdb/obs-inf-prs /pkg/util/stop @cockroachdb/server-prs /pkg/util/tracing @cockroachdb/obs-inf-prs -/pkg/workload/ @cockroachdb/sql-sessions-noreview +/pkg/workload/ @cockroachdb/sql-foundations-noreview # Allow the security team to have insight into changes to # authn/authz code. diff --git a/TEAMS.yaml b/TEAMS.yaml index 455333c474f0..4279fd1f6fe9 100644 --- a/TEAMS.yaml +++ b/TEAMS.yaml @@ -19,15 +19,13 @@ cockroachdb/docs: triage_column_id: 3971225 -cockroachdb/sql-sessions: +cockroachdb/sql-foundations: aliases: cockroachdb/sql-syntax-prs: other cockroachdb/sqlproxy-prs: other cockroachdb/sql-api-prs: other - triage_column_id: 7259065 - label: T-sql-sessions -cockroachdb/sql-schema: - triage_column_id: 8946818 + triage_column_id: 19467489 + label: T-sql-foundations cockroachdb/sql-queries: aliases: cockroachdb/sql-optimizer: other diff --git a/pkg/cmd/roachtest/registry/owners.go b/pkg/cmd/roachtest/registry/owners.go index 6fe998b13912..6399c1bc3b4b 100644 --- a/pkg/cmd/roachtest/registry/owners.go +++ b/pkg/cmd/roachtest/registry/owners.go @@ -16,7 +16,7 @@ type Owner string // The allowable values of Owner. const ( - OwnerSQLExperience Owner = `sql-sessions` + OwnerSQLFoundations Owner = `sql-foundations` OwnerDisasterRecovery Owner = `disaster-recovery` OwnerCDC Owner = `cdc` OwnerKV Owner = `kv` @@ -25,7 +25,6 @@ const ( OwnerObsInf Owner = `obs-inf-prs` OwnerServer Owner = `server` OwnerSQLQueries Owner = `sql-queries` - OwnerSQLSchema Owner = `sql-schema` OwnerStorage Owner = `storage` OwnerTestEng Owner = `test-eng` OwnerDevInf Owner = `dev-inf` diff --git a/pkg/cmd/roachtest/tests/activerecord.go b/pkg/cmd/roachtest/tests/activerecord.go index 84e603d1817f..a7386e938978 100644 --- a/pkg/cmd/roachtest/tests/activerecord.go +++ b/pkg/cmd/roachtest/tests/activerecord.go @@ -251,7 +251,7 @@ func registerActiveRecord(r registry.Registry) { r.Add(registry.TestSpec{ Name: "activerecord", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `orm`}, Run: runActiveRecord, diff --git a/pkg/cmd/roachtest/tests/alterpk.go b/pkg/cmd/roachtest/tests/alterpk.go index e7e4a95a6d1a..a55290c540d3 100644 --- a/pkg/cmd/roachtest/tests/alterpk.go +++ b/pkg/cmd/roachtest/tests/alterpk.go @@ -172,7 +172,7 @@ func registerAlterPK(r registry.Registry) { } r.Add(registry.TestSpec{ Name: "alterpk-bank", - Owner: registry.OwnerSQLSchema, + Owner: registry.OwnerSQLFoundations, // Use a 4 node cluster -- 3 nodes will run cockroach, and the last will be the // workload driver node. Cluster: r.MakeClusterSpec(4), @@ -180,7 +180,7 @@ func registerAlterPK(r registry.Registry) { }) r.Add(registry.TestSpec{ Name: "alterpk-tpcc-250", - Owner: registry.OwnerSQLSchema, + Owner: registry.OwnerSQLFoundations, // Use a 4 node cluster -- 3 nodes will run cockroach, and the last will be the // workload driver node. Cluster: r.MakeClusterSpec(4, spec.CPU(32)), @@ -190,7 +190,7 @@ func registerAlterPK(r registry.Registry) { }) r.Add(registry.TestSpec{ Name: "alterpk-tpcc-500", - Owner: registry.OwnerSQLSchema, + Owner: registry.OwnerSQLFoundations, // Use a 4 node cluster -- 3 nodes will run cockroach, and the last will be the // workload driver node. Cluster: r.MakeClusterSpec(4, spec.CPU(16)), diff --git a/pkg/cmd/roachtest/tests/asyncpg.go b/pkg/cmd/roachtest/tests/asyncpg.go index 884e658e1964..b59005604eb0 100644 --- a/pkg/cmd/roachtest/tests/asyncpg.go +++ b/pkg/cmd/roachtest/tests/asyncpg.go @@ -139,7 +139,7 @@ func registerAsyncpg(r registry.Registry) { r.Add(registry.TestSpec{ Name: "asyncpg", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1, spec.CPU(16)), Tags: []string{`default`, `orm`}, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/connection_latency.go b/pkg/cmd/roachtest/tests/connection_latency.go index 09f4b89253a4..44e64ff8bab6 100644 --- a/pkg/cmd/roachtest/tests/connection_latency.go +++ b/pkg/cmd/roachtest/tests/connection_latency.go @@ -118,7 +118,7 @@ func registerConnectionLatencyTest(r registry.Registry) { numNodes := 3 r.Add(registry.TestSpec{ Name: fmt.Sprintf("connection_latency/nodes=%d/certs", numNodes), - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, // Add one more node for load node. Cluster: r.MakeClusterSpec(numNodes+1, spec.Zones(regionUsCentral)), Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { @@ -134,7 +134,7 @@ func registerConnectionLatencyTest(r registry.Registry) { r.Add(registry.TestSpec{ Name: fmt.Sprintf("connection_latency/nodes=%d/multiregion/certs", numMultiRegionNodes), - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(numMultiRegionNodes+loadNodes, spec.Geo(), spec.Zones(geoZonesStr)), Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { runConnectionLatencyTest(ctx, t, c, numMultiRegionNodes, numZones, false /*password*/) @@ -143,7 +143,7 @@ func registerConnectionLatencyTest(r registry.Registry) { r.Add(registry.TestSpec{ Name: fmt.Sprintf("connection_latency/nodes=%d/multiregion/password", numMultiRegionNodes), - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(numMultiRegionNodes+loadNodes, spec.Geo(), spec.Zones(geoZonesStr)), Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { runConnectionLatencyTest(ctx, t, c, numMultiRegionNodes, numZones, true /*password*/) diff --git a/pkg/cmd/roachtest/tests/django.go b/pkg/cmd/roachtest/tests/django.go index 57df5370a8cd..601abc543af3 100644 --- a/pkg/cmd/roachtest/tests/django.go +++ b/pkg/cmd/roachtest/tests/django.go @@ -236,7 +236,7 @@ func registerDjango(r registry.Registry) { r.Add(registry.TestSpec{ Name: "django", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1, spec.CPU(16)), Tags: []string{`default`, `orm`}, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/drain.go b/pkg/cmd/roachtest/tests/drain.go index 36e3ac1a025a..3eab666cc047 100644 --- a/pkg/cmd/roachtest/tests/drain.go +++ b/pkg/cmd/roachtest/tests/drain.go @@ -38,7 +38,7 @@ func registerDrain(r registry.Registry) { { r.Add(registry.TestSpec{ Name: "drain/early-exit-conn-wait", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { runEarlyExitInConnectionWait(ctx, t, c) @@ -47,7 +47,7 @@ func registerDrain(r registry.Registry) { r.Add(registry.TestSpec{ Name: "drain/warn-conn-wait-timeout", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { runWarningForConnWait(ctx, t, c) @@ -56,7 +56,7 @@ func registerDrain(r registry.Registry) { r.Add(registry.TestSpec{ Name: "drain/not-at-quorum", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(3), Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { runClusterNotAtQuorum(ctx, t, c) diff --git a/pkg/cmd/roachtest/tests/flowable.go b/pkg/cmd/roachtest/tests/flowable.go index 81f63f904dc5..1f53fb797c8c 100644 --- a/pkg/cmd/roachtest/tests/flowable.go +++ b/pkg/cmd/roachtest/tests/flowable.go @@ -104,7 +104,7 @@ func registerFlowable(r registry.Registry) { r.Add(registry.TestSpec{ Name: "flowable", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { runFlowable(ctx, t, c) diff --git a/pkg/cmd/roachtest/tests/gopg.go b/pkg/cmd/roachtest/tests/gopg.go index d07a8bd18253..29f09a7b0951 100644 --- a/pkg/cmd/roachtest/tests/gopg.go +++ b/pkg/cmd/roachtest/tests/gopg.go @@ -164,7 +164,7 @@ func registerGopg(r registry.Registry) { r.Add(registry.TestSpec{ Name: "gopg", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `orm`}, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/gorm.go b/pkg/cmd/roachtest/tests/gorm.go index 58342d88b867..762f7e2ee05b 100644 --- a/pkg/cmd/roachtest/tests/gorm.go +++ b/pkg/cmd/roachtest/tests/gorm.go @@ -134,7 +134,7 @@ func registerGORM(r registry.Registry) { r.Add(registry.TestSpec{ Name: "gorm", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `orm`}, Run: runGORM, diff --git a/pkg/cmd/roachtest/tests/hibernate.go b/pkg/cmd/roachtest/tests/hibernate.go index 0bd0949a1477..6fed68154f10 100644 --- a/pkg/cmd/roachtest/tests/hibernate.go +++ b/pkg/cmd/roachtest/tests/hibernate.go @@ -238,7 +238,7 @@ func registerHibernate(r registry.Registry, opt hibernateOptions) { r.Add(registry.TestSpec{ Name: opt.testName, - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `orm`}, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/inverted_index.go b/pkg/cmd/roachtest/tests/inverted_index.go index 49dfdebdb843..f1ebed589511 100644 --- a/pkg/cmd/roachtest/tests/inverted_index.go +++ b/pkg/cmd/roachtest/tests/inverted_index.go @@ -26,7 +26,7 @@ import ( func registerSchemaChangeInvertedIndex(r registry.Registry) { r.Add(registry.TestSpec{ Name: "schemachange/invertedindex", - Owner: registry.OwnerSQLSchema, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(5), Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { runSchemaChangeInvertedIndex(ctx, t, c) diff --git a/pkg/cmd/roachtest/tests/jasyncsql.go b/pkg/cmd/roachtest/tests/jasyncsql.go index f5051cc34325..2830bbebd41b 100644 --- a/pkg/cmd/roachtest/tests/jasyncsql.go +++ b/pkg/cmd/roachtest/tests/jasyncsql.go @@ -148,7 +148,7 @@ func registerJasyncSQL(r registry.Registry) { r.Add(registry.TestSpec{ Name: "jasync", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `orm`}, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/knex.go b/pkg/cmd/roachtest/tests/knex.go index 73b3e8c9b42b..a830078e0c6d 100644 --- a/pkg/cmd/roachtest/tests/knex.go +++ b/pkg/cmd/roachtest/tests/knex.go @@ -121,7 +121,7 @@ func registerKnex(r registry.Registry) { r.Add(registry.TestSpec{ Name: "knex", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `orm`}, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/libpq.go b/pkg/cmd/roachtest/tests/libpq.go index babc76cb48eb..dabee3a576c7 100644 --- a/pkg/cmd/roachtest/tests/libpq.go +++ b/pkg/cmd/roachtest/tests/libpq.go @@ -140,7 +140,7 @@ func registerLibPQ(r registry.Registry) { r.Add(registry.TestSpec{ Name: "lib/pq", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `driver`}, Run: runLibPQ, diff --git a/pkg/cmd/roachtest/tests/liquibase.go b/pkg/cmd/roachtest/tests/liquibase.go index 1085cbe86cfe..019e3bb4ff9c 100644 --- a/pkg/cmd/roachtest/tests/liquibase.go +++ b/pkg/cmd/roachtest/tests/liquibase.go @@ -132,7 +132,7 @@ func registerLiquibase(r registry.Registry) { r.Add(registry.TestSpec{ Name: "liquibase", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `tool`}, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/mixed_version_schemachange.go b/pkg/cmd/roachtest/tests/mixed_version_schemachange.go index d67433fae2c2..25700b6f5b95 100644 --- a/pkg/cmd/roachtest/tests/mixed_version_schemachange.go +++ b/pkg/cmd/roachtest/tests/mixed_version_schemachange.go @@ -23,7 +23,7 @@ import ( func registerSchemaChangeMixedVersions(r registry.Registry) { r.Add(registry.TestSpec{ Name: "schemachange/mixed-versions", - Owner: registry.OwnerSQLSchema, + Owner: registry.OwnerSQLFoundations, // This tests the work done for 20.1 that made schema changes jobs and in // addition prevented making any new schema changes on a mixed cluster in // order to prevent bugs during upgrades. diff --git a/pkg/cmd/roachtest/tests/nodejs_postgres.go b/pkg/cmd/roachtest/tests/nodejs_postgres.go index 9065511956aa..90b2549b784a 100644 --- a/pkg/cmd/roachtest/tests/nodejs_postgres.go +++ b/pkg/cmd/roachtest/tests/nodejs_postgres.go @@ -168,7 +168,7 @@ PGSSLCERT=$HOME/certs/client.%s.crt PGSSLKEY=$HOME/certs/client.%s.key PGSSLROOT r.Add(registry.TestSpec{ Name: "node-postgres", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `driver`}, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/pgjdbc.go b/pkg/cmd/roachtest/tests/pgjdbc.go index e621c8fc8e27..04c5181eac98 100644 --- a/pkg/cmd/roachtest/tests/pgjdbc.go +++ b/pkg/cmd/roachtest/tests/pgjdbc.go @@ -212,7 +212,7 @@ func registerPgjdbc(r registry.Registry) { r.Add(registry.TestSpec{ Name: "pgjdbc", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `driver`}, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/pgx.go b/pkg/cmd/roachtest/tests/pgx.go index eacaeba3a35d..fc6f786d692b 100644 --- a/pkg/cmd/roachtest/tests/pgx.go +++ b/pkg/cmd/roachtest/tests/pgx.go @@ -140,7 +140,7 @@ func registerPgx(r registry.Registry) { r.Add(registry.TestSpec{ Name: "pgx", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `driver`}, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/pop.go b/pkg/cmd/roachtest/tests/pop.go index 5c0bd2580aa7..1f1000e7a36d 100644 --- a/pkg/cmd/roachtest/tests/pop.go +++ b/pkg/cmd/roachtest/tests/pop.go @@ -100,7 +100,7 @@ func registerPop(r registry.Registry) { r.Add(registry.TestSpec{ Name: "pop", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `orm`}, Run: runPop, diff --git a/pkg/cmd/roachtest/tests/psycopg.go b/pkg/cmd/roachtest/tests/psycopg.go index b9de3e7ca68f..e647ec84ccbb 100644 --- a/pkg/cmd/roachtest/tests/psycopg.go +++ b/pkg/cmd/roachtest/tests/psycopg.go @@ -148,7 +148,7 @@ func registerPsycopg(r registry.Registry) { r.Add(registry.TestSpec{ Name: "psycopg", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `driver`}, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/remove_invalid_database_privileges.go b/pkg/cmd/roachtest/tests/remove_invalid_database_privileges.go index 6b279a7dc1c6..10cb1170d94b 100644 --- a/pkg/cmd/roachtest/tests/remove_invalid_database_privileges.go +++ b/pkg/cmd/roachtest/tests/remove_invalid_database_privileges.go @@ -24,7 +24,7 @@ import ( func registerRemoveInvalidDatabasePrivileges(r registry.Registry) { r.Add(registry.TestSpec{ Name: "remove-invalid-database-privileges", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(3), Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { runRemoveInvalidDatabasePrivileges(ctx, t, c, *t.BuildVersion()) diff --git a/pkg/cmd/roachtest/tests/ruby_pg.go b/pkg/cmd/roachtest/tests/ruby_pg.go index a02282c9cb42..6f41511c3752 100644 --- a/pkg/cmd/roachtest/tests/ruby_pg.go +++ b/pkg/cmd/roachtest/tests/ruby_pg.go @@ -232,7 +232,7 @@ func registerRubyPG(r registry.Registry) { r.Add(registry.TestSpec{ Name: "ruby-pg", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `orm`}, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/schema_change_database_version_upgrade.go b/pkg/cmd/roachtest/tests/schema_change_database_version_upgrade.go index 3178892f2ebd..7cf1d8adee8c 100644 --- a/pkg/cmd/roachtest/tests/schema_change_database_version_upgrade.go +++ b/pkg/cmd/roachtest/tests/schema_change_database_version_upgrade.go @@ -38,7 +38,7 @@ func registerSchemaChangeDatabaseVersionUpgrade(r registry.Registry) { // TODO (lucy): Remove this test in 21.1. r.Add(registry.TestSpec{ Name: "schemachange/database-version-upgrade", - Owner: registry.OwnerSQLSchema, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(3), Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { runSchemaChangeDatabaseVersionUpgrade(ctx, t, c, *t.BuildVersion()) diff --git a/pkg/cmd/roachtest/tests/schemachange.go b/pkg/cmd/roachtest/tests/schemachange.go index 3b2d747e4f92..2667f915b664 100644 --- a/pkg/cmd/roachtest/tests/schemachange.go +++ b/pkg/cmd/roachtest/tests/schemachange.go @@ -30,7 +30,7 @@ import ( func registerSchemaChangeDuringKV(r registry.Registry) { r.Add(registry.TestSpec{ Name: `schemachange/during/kv`, - Owner: registry.OwnerSQLSchema, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(5), Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { const fixturePath = `gs://cockroach-fixtures/workload/tpch/scalefactor=10/backup?AUTH=implicit` @@ -306,7 +306,7 @@ func makeIndexAddTpccTest( ) registry.TestSpec { return registry.TestSpec{ Name: fmt.Sprintf("schemachange/index/tpcc/w=%d", warehouses), - Owner: registry.OwnerSQLSchema, + Owner: registry.OwnerSQLFoundations, Cluster: spec, Timeout: length * 3, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { @@ -338,7 +338,7 @@ func makeSchemaChangeBulkIngestTest( ) registry.TestSpec { return registry.TestSpec{ Name: "schemachange/bulkingest", - Owner: registry.OwnerSQLSchema, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(numNodes), Timeout: length * 2, // `fixtures import` (with the workload paths) is not supported in 2.1 @@ -424,7 +424,7 @@ func makeSchemaChangeDuringTPCC( ) registry.TestSpec { return registry.TestSpec{ Name: "schemachange/during/tpcc", - Owner: registry.OwnerSQLSchema, + Owner: registry.OwnerSQLFoundations, Cluster: spec, Timeout: length * 3, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/schemachange_random_load.go b/pkg/cmd/roachtest/tests/schemachange_random_load.go index 2fff42253246..51472dc3930d 100644 --- a/pkg/cmd/roachtest/tests/schemachange_random_load.go +++ b/pkg/cmd/roachtest/tests/schemachange_random_load.go @@ -39,7 +39,7 @@ func registerSchemaChangeRandomLoad(r registry.Registry) { geoZonesStr := strings.Join(geoZones, ",") r.Add(registry.TestSpec{ Name: "schemachange/random-load", - Owner: registry.OwnerSQLSchema, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec( 3, spec.Geo(), @@ -85,7 +85,7 @@ func registerRandomLoadBenchSpec(r registry.Registry, b randomLoadBenchSpec) { r.Add(registry.TestSpec{ Name: name, - Owner: registry.OwnerSQLSchema, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(b.Nodes), Skip: "https://github.com/cockroachdb/cockroach/issues/56230", // This is set while development is still happening on the workload and we diff --git a/pkg/cmd/roachtest/tests/secondary_indexes.go b/pkg/cmd/roachtest/tests/secondary_indexes.go index ee48dc30d9b4..60e852fc287a 100644 --- a/pkg/cmd/roachtest/tests/secondary_indexes.go +++ b/pkg/cmd/roachtest/tests/secondary_indexes.go @@ -137,7 +137,7 @@ func verifyTableData(node int, expected [][]int) versionStep { func registerSecondaryIndexesMultiVersionCluster(r registry.Registry) { r.Add(registry.TestSpec{ Name: "schemachange/secondary-index-multi-version", - Owner: registry.OwnerSQLSchema, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(3), Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { predV, err := PredecessorVersion(*t.BuildVersion()) diff --git a/pkg/cmd/roachtest/tests/sequelize.go b/pkg/cmd/roachtest/tests/sequelize.go index dfafeaf55148..733640fd9819 100644 --- a/pkg/cmd/roachtest/tests/sequelize.go +++ b/pkg/cmd/roachtest/tests/sequelize.go @@ -154,7 +154,7 @@ func registerSequelize(r registry.Registry) { r.Add(registry.TestSpec{ Name: "sequelize", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `orm`}, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/sqlalchemy.go b/pkg/cmd/roachtest/tests/sqlalchemy.go index 8dc6f1646fdc..51db54f78a58 100644 --- a/pkg/cmd/roachtest/tests/sqlalchemy.go +++ b/pkg/cmd/roachtest/tests/sqlalchemy.go @@ -37,7 +37,7 @@ var supportedSQLAlchemyTag = "2.0.2" func registerSQLAlchemy(r registry.Registry) { r.Add(registry.TestSpec{ Name: "sqlalchemy", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `orm`}, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/typeorm.go b/pkg/cmd/roachtest/tests/typeorm.go index d419bb473cdc..72e378898422 100644 --- a/pkg/cmd/roachtest/tests/typeorm.go +++ b/pkg/cmd/roachtest/tests/typeorm.go @@ -178,7 +178,7 @@ func registerTypeORM(r registry.Registry) { r.Add(registry.TestSpec{ Name: "typeorm", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(1), Tags: []string{`default`, `orm`}, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { diff --git a/pkg/cmd/roachtest/tests/validate_grant_option.go b/pkg/cmd/roachtest/tests/validate_grant_option.go index 8d1ba174ec26..c7e355d57729 100644 --- a/pkg/cmd/roachtest/tests/validate_grant_option.go +++ b/pkg/cmd/roachtest/tests/validate_grant_option.go @@ -23,7 +23,7 @@ import ( func registerValidateGrantOption(r registry.Registry) { r.Add(registry.TestSpec{ Name: "validate-grant-option", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(3), Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { runRegisterValidateGrantOption(ctx, t, c, *t.BuildVersion()) diff --git a/pkg/cmd/roachtest/tests/version_upgrade_public_schema.go b/pkg/cmd/roachtest/tests/version_upgrade_public_schema.go index 89e271e0c6d6..c6d038b7b790 100644 --- a/pkg/cmd/roachtest/tests/version_upgrade_public_schema.go +++ b/pkg/cmd/roachtest/tests/version_upgrade_public_schema.go @@ -27,7 +27,7 @@ import ( func registerVersionUpgradePublicSchema(r registry.Registry) { r.Add(registry.TestSpec{ Name: "versionupgrade/publicschema", - Owner: registry.OwnerSQLExperience, + Owner: registry.OwnerSQLFoundations, Cluster: r.MakeClusterSpec(3), Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { runVersionUpgradePublicSchema(ctx, t, c, *t.BuildVersion())