multiregionccl: gate multi-region database configuration behind a license #61041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
mulah_for_multiregion
branch
3 times, most recently
from
6e3c268
to
fa22251
Compare
otan
force-pushed
the
mulah_for_multiregion
branch
from
fa22251
to
521815c
Compare
ajstorm
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @otan)
pkg/ccl/multiregionccl/multiregion_test.go, line 92 at r1 (raw file):
// The previous command on t4 does some async cleanup // which may require retries for the DROP COLUMN to succeed. {stmt: `ALTER TABLE t4 DROP COLUMN crdb_region`, retry: true},
Nit: Does this mean that ALTER DATABASE ADD REGION will still work? Not essential, but would be nice if we blocked that as well.
|
pkg/ccl/multiregionccl/multiregion_test.go, line 92 at r1 (raw file): Previously, ajstorm (Adam Storm) wrote…
upcoming PR |
otan
force-pushed
the
mulah_for_multiregion
branch
3 times, most recently
from
9a8d34c
to
7a128a6
Compare
…ense Release justification: low risk changes to new functionality Release note (enterprise change): Multi-region database creations are permitted as long as the cluster has a CockroachDB subscription.
otan
force-pushed
the
mulah_for_multiregion
branch
from
7a128a6
to
c0fda09
Compare
|
bors r=ajstorm |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #59668
Release justification: low risk changes to new functionality
Release note (enterprise change): Multi-region database creations are
permitted as long as the cluster has a CockroachDB subscription.