From 7c8d747816e6c675ce4eeb1afea208b6b90c4114 Mon Sep 17 00:00:00 2001 From: Steven Danna Date: Fri, 12 Aug 2022 13:46:22 +0100 Subject: [PATCH] kvserver: use static tracing span name for AddSSTable Including the span bounds in the name of the tracing span means that we can't aggregate information across all AddSSTable calls. Release note: None --- pkg/kv/kvserver/batcheval/cmd_add_sstable.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kv/kvserver/batcheval/cmd_add_sstable.go b/pkg/kv/kvserver/batcheval/cmd_add_sstable.go index 3fd05266cead..5ab1e4df2313 100644 --- a/pkg/kv/kvserver/batcheval/cmd_add_sstable.go +++ b/pkg/kv/kvserver/batcheval/cmd_add_sstable.go @@ -125,7 +125,7 @@ func EvalAddSSTable( var span *tracing.Span var err error - ctx, span = tracing.ChildSpan(ctx, fmt.Sprintf("AddSSTable [%s,%s)", start.Key, end.Key)) + ctx, span = tracing.ChildSpan(ctx, "AddSSTable") defer span.Finish() log.Eventf(ctx, "evaluating AddSSTable [%s,%s)", start.Key, end.Key)