Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up JWT validation #15

Open
spacedub opened this issue May 26, 2023 · 1 comment
Open

Hook up JWT validation #15

spacedub opened this issue May 26, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request P0 Must have
Milestone

Comments

@spacedub
Copy link
Contributor

Code is here, but has to be put in properly:

https://github.com/codecomet-io/kohoutek/blob/main/app/src/lib/verify-authentication.server.ts#L74

  1. key should be loaded only once, at startup
  2. key should be put in configuration
  3. verification is async in nature and process should be adapted to accommodate that
  4. should be tested... specifically, not clear if the thing just throws or what else it returns

In itself, this is critical, just not right now :)

Tagging @briznad

@spacedub spacedub added the P0 Must have label May 26, 2023
@spacedub spacedub added this to the Next milestone May 26, 2023
@spacedub spacedub added the enhancement New feature or request label May 26, 2023
@spacedub
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P0 Must have
Projects
None yet
Development

No branches or pull requests

2 participants