Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest#write blindly casts bytes to chars #20

Closed
michael-o opened this issue Jan 1, 2016 · 1 comment
Closed

Manifest#write blindly casts bytes to chars #20

michael-o opened this issue Jan 1, 2016 · 1 comment
Assignees
@michael-o
Labels
bug
Milestone
3.3

Comments

@michael-o
Copy link
Member 

for ( byte b : byteArrayOutputStream.toByteArray() )
  {
    writer.write( (char) b );
  }

This loop is error-prone because a byte does not necessarily represent a char. If a multibyte character is encountered, the output will be mangled.
@michael-o michael-o mentioned this issue May 20, 2016
Closed
@michael-o
Copy link
Member Author

The code in question is targeted for removal in 4.0?!

@michael-o michael-o added the bug label May 20, 2016
@michael-o michael-o added this to the 3.3 milestone May 20, 2016
@michael-o michael-o self-assigned this May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-o michael-o

Labels
bug
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
1 participant
@michael-o