[tern addon] Add caseInsensitive autocompletion option

[zz85]

• allow caseInsensitive option eg.
  server = new CodeMirror.TernServer({caseInsensitive: true});
• caseInsensitive is passed to tern request query which allow case insensitive autocomplete searches

relates to ternjs/tern#163

[mrdoob]

Just a suggestion. Maybe caseSensitive true by default would be more clear.

[zz85]

hmm yes, double negatives... i used caseInsensitive following ternjs's change. let's see what @marijnh thinks :)

[marijnh]

Please take a look at the attached patch instead. It adds a more general way to add options to queries. You'd pass it queryOptions: {completions: {caseInsensitive: true}} to get the effect you want. Does this work for you?

As for the double negative, I agree that's bad style, but that ship has sailed (it is part of the Tern API, and I don't consider it a big enough problem to change it now).

[zz85]

@marijnh hmm. let me test that.

but from my first looks it seems like queryOptions: {completions: {caseInsensitive: true}} might override any properties already in query.completions, unless usage of .request() ever pass in a completions property.

do you think it would be better to have a query hook filter option which takes a function instead (which might be even more flexible)?

[zz85]

quick test with queryOptions: {completions: {caseInsensitive: true}} works.

[marijnh]

I am not sure I understand your concern. Yes, queryOptions could override properties that the library itself added, and you could pass something like {type: "foo"} and break the library. But why would you?

[zz85]

maybe my concerns are unfounded, but looks like this issue has been resolve, so I'll close this. Thanks!