Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting safe area x = 0 y = 132 size = width = 1125 height = 2202 #3024

Closed
jsfan3 opened this issue Feb 12, 2020 · 2 comments
Closed

Getting safe area x = 0 y = 132 size = width = 1125 height = 2202 #3024

jsfan3 opened this issue Feb 12, 2020 · 2 comments

Comments

@jsfan3
Copy link
Contributor

jsfan3 commented Feb 12, 2020

Every time that I tap on a tab, I get in the log something like:

Getting safe area x = 0 y = 132 size = width = 1125 height = 2202

I suppose that this should be hidden.
@shannah
Copy link
Collaborator

shannah commented Feb 12, 2020

This was fixed as a part of 9fc2b4b

@shannah shannah closed this as completed Feb 12, 2020
@jsfan3
Copy link
Contributor Author

jsfan3 commented Feb 13, 2020 •
edited
Loading

After your answer, I updated my local clone of the CN1 sources (to compile against that), but this issue still happens.

shannah added a commit that referenced this issue Feb 14, 2020
@shannah
Removed debugging text for safe area (#3024)
03245c6 
Added some more nuance to layout of children inside scrollable containers with the constrainWidthWhenScrollable() and constrainHeightWhenScrollable() methods.
Moved DataChangeListener and DoneListener support into TextArea from TextField so that these are available for multi-line fields.
Changed behaviour of JavaSE multiline text areas when a done listener is assigned to the TextArea.  Enter will now fire done event.  Shift-enter will do what enter used to do - add a newline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsfan3 @shannah