Aligned iOS local fg notification behavior with Android (localNotificationReceived only triggers when tapped, not when shown) #3348
Conversation
…ationReceived only triigers when tapped, not when shown)
javieranton-zz
changed the title
|
Hi, I must have missed your 13 day old comment. Apologies, I was convinced there wasn't a reply. To answer your question: yes, I have tested this extensively. Like thousands of times, I also have released builds with these modifications and tested in production. I always end up having to edit the delegate so all merging this will do is just save me having to do that. But I thought it would make sense for everyone too if it behaved this way I have tested on iOS 10 and iOS 13, so if you can test on lower versions that would be great too (I don't have any device with lower than iOS 10) In older iOS versions, local notifs will still go straight to localNotifReceived, but I guess that's fine |
|
This will have to wait to next week as we're in code freeze for 7.0. Please ping us again in the middle of next week and we'll try to merge it assuming @shannah has no objections. |
No worries Shai, I'll try to remember |
|
Ping. TBH, I'm not sure this should be merged. There is a clear user benefit but unless someone can fully test this with CN1's push it might break things. I implement my own push so no matter how much I test it won't cover all scenarios. OK to close |
As of today, after @shannah latest changes that enabled iOS foreground notifications, iOS triggers a call to localNotificationReceived as soon as a local notification is received
Android however only does this when the local foreground notification is tapped, which makes more sense
This change makes iOS behave same as Android