feat(lambda): Added package_path and package_s3 inputs #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mskrajnowski
requested review from
cq-fpietron,
karwer,
TarasJan and
Aritzaranburu
karwer
approved these changes
Jan 27, 2021
lambda/layer/main.tf
Outdated
| @@ -1,6 +1,14 @@ | |||
| locals { | |||
| package_s3_match = var.package_s3 != null ? regex( | |||
There was a problem hiding this comment.
Does it work with key of a nested object? Probably it does :) Do you prefer this package_s3 approach rather than package_s3_bucket and package_s3_object instead?
There was a problem hiding this comment.
converted package_s3 to a {bucket, key} object in 1c986b9
mskrajnowski
force-pushed
the
feat/lambda-layers
branch
from
c547dba
to
3a23b43
Compare
…cted files* inputs
…ted files* inputs
mskrajnowski
force-pushed
the
feat/lambda-sources
branch
from
76c00b4
to
1c986b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package_pathinput tolambdaandlambda/layermodules, so you can provide any zip filepackage_s3andpackage_s3_versioninputs tolambdaandlambda/layermodules, so a zip file can be added from an S3 bucketimageinput tolambdamodule to create a lambda based on a container imagefilesand files_dirinputs with a recommendation to build z zip using thezip` moduleTo do:
Decide what to do withMoved to feat(lambda)!: create lambda from a container image #105imageinput, since it requires bumping the AWS provider to>= 3.19which includes [REGRESSION] v3.13.0 causes perpetual diff of resources containing lambda version number hashicorp/terraform-provider-aws#15952