New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit hook has empty export #4

Open

bassam opened this issue Dec 2, 2018 · 1 comment

bassam commented Dec 2, 2018

I have enabled dco and my commit hook has an empty export line:

cat .git/hooks/commit-msg
#!/bin/sh
# INSTALLED BY DCO GEM
export
/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby /Library/Ruby/Gems/2.3.0/gems/dco-1.0.1/bin/dco process_commit_message $1
exit $?

on macOS the prints out all export on every commit. looks like this line is the cultprit:

https://github.com/coderanger/dco/blob/master/lib/dco/cli.rb#L147

The text was updated successfully, but these errors were encountered:

Owner

coderanger commented Dec 2, 2018

Hmm, might be easier to change the whole thing to exec env #{env stuff} #{ruby stuff}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment