Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1-fix-responsive-navbar-code-enhancements #2

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

asbhogal
Copy link
Collaborator

@asbhogal asbhogal commented Jun 13, 2023

The following changes have been made:

  • JS logic has been applied to dynamically add/remove an '.active' class to the header links when clicked, using forEach which cycles through all the elements and adds an event listener to the nav links to monitor a user click. When a list item is clicked, the class is removed from the previously clicked link item and subsequently added to the currently clicked list item. Because Bootstrap is configured, the styling for 'active' has !important added to override this. The manually added '.active' class has also been removed, and a 'nav-link' class has been added to the font-awesome home icon to ensure this is also targetted when clicked.
  • Hamburger menu toggle disappearing on close has been resolved by changing the
    id and data-bs-target values to "#navbarCollapse" to avoid conflict with previously the same value of "#navbarNav" (as the button is supposed to toggle the visibility of the
    element with the corresponding data-bs-target value). The aria-controls value has also been subsequently changed.
  • CSS code refactoring, incl. using the :where pseudo-class function to target specific elements in the header (h1, h2, h4, a)
  • Typo of 'autor' in media query amended to 'author'
  • Vite has been configured to allow for real-time development changes. Directories have remained unchanged

@asbhogal asbhogal linked an issue Jun 13, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for iceland-landing-page ready!

Name Link
🔨 Latest commit 227c54f
🔍 Latest deploy log https://app.netlify.com/sites/iceland-landing-page/deploys/64886f5725dab50007e58902
😎 Deploy Preview https://deploy-preview-2--iceland-landing-page.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@asbhogal asbhogal self-assigned this Jun 13, 2023
@asbhogal asbhogal added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix/responsive-navbar-code-enhancements
1 participant