New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve assertions #126

Merged

norberttech merged 1 commit into coduo:4.x from open-source-contributions:test_enhancement

Mar 12, 2021

Contributor

peter279k commented Mar 9, 2021 •

edited

Loading

Change Log

Changed

Using the `assertTrue` to assert expected is `true`.
Using the `assertFalse` to assert expected is `false`.


          Improve assertions

b3ae970

Member

norberttech commented Mar 11, 2021

Hey @peter279k could you please update your PR description according to this template: https://github.com/coduo/php-humanizer/blob/4.x/.github/PULL_REQUEST_TEMPLATE.md ?

The HTML is required for https://github.com/aeon-php/automation to extract description of your changes and put them into the https://github.com/coduo/php-humanizer/blob/4.x/CHANGELOG.md file later

Thanks!

norberttech merged commit 77e2f49 into coduo:4.x

peter279k deleted the test_enhancement branch

March 12, 2021 15:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet