Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Portuguese (pt) language translation (with spec tests) #31

Merged
merged 1 commit into from
Oct 29, 2015
Merged

Addition of Portuguese (pt) language translation (with spec tests) #31

merged 1 commit into from
Oct 29, 2015

Conversation

lightglitch
Copy link
Contributor

Hi,

In terms of context of the translations when you have the text:

%count% seconds from now

you mean the same as:

in about %count% seconds

or

in %count% seconds

Because the translation of the second sentence makes more sense to me in Portuguese and if it's the same for you I will change the texts.

PS: I'm also getting some errors in the tests for Numbers in my machine but I will look into that later.

norberttech pushed a commit that referenced this pull request Oct 29, 2015
Addition of Portuguese (pt) language translation (with spec tests)
@norberttech norberttech merged commit e7fad9a into coduo:master Oct 29, 2015
@norberttech
Copy link
Member

@lightglitch thanks a lot!

@lightglitch
Copy link
Contributor Author

@norzechowicz Did you see my doubt in the description?

@norberttech
Copy link
Member

about the in %count% seconds ?

@lightglitch
Copy link
Contributor Author

Yep.

@norberttech
Copy link
Member

well it depends if this gonna works for all other languages. I see the point for english, for polish also. It would be something like za %count% sekund but not sure about the others.

@lightglitch
Copy link
Contributor Author

I think that in Portuguese the meaning is more or less the same but the second sounds better, I will update for Portuguese as soon as I can.

@norberttech
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants