Truncate check length of append #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2015 17:59
| @@ -33,7 +33,7 @@ public function __construct($text, $charactersCount, $append = '') | |||
|
|
|||
| public function __toString() | |||
| { | |||
| if ($this->charactersCount < 0 || strlen($this->text) <= $this->charactersCount) { | |||
| if ($this->charactersCount < 0 || strlen($this->text) <= ($this->charactersCount + mb_strlen($this->append))) { | |||
There was a problem hiding this comment.
Maybe we should switch to mb_strlen everywhere?
There was a problem hiding this comment.
I just find out that we have more places like that, I gonna merge it now and prepare separated PR for switching to mb_* functions
There was a problem hiding this comment.
Yeah, that's a good idea, i've had quite a bit of problems with multibyte string being french where we have stange characters everywhere ! You should add some test in strange charset like arabic/persian (علی) (see: http://stackoverflow.com/questions/25599981/how-can-i-use-strlen-in-php-for-persian)
norberttech
pushed a commit
that referenced
this pull request
Oct 29, 2015
Truncate check length of append
|
@smeeckaert nice catch! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug when the size to troncate + the size of the append is the same as the string length.
This cause even a more bigger issue because it doesn't check for a breakpoint since there are no more space in the string thus abruptly cuting the string.