Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MathOperation : Support Multiply / Division Operation #239

Closed
thanhnguyennguyen opened this issue Nov 14, 2020 · 1 comment · Fixed by #316
Closed

MathOperation : Support Multiply / Division Operation #239

thanhnguyennguyen opened this issue Nov 14, 2020 · 1 comment · Fixed by #316
Labels
enhancement New feature or request

Comments

@thanhnguyennguyen
Copy link

Is your feature request related to a problem? Please describe.
Calculation on balance need more operations. Now, only addition and subtraction are supported. It's great to have multiply and division

Describe the solution you'd like
Support Support Multiply / Division Operation https://github.com/coinbase/rosetta-sdk-go/blob/1e2b4a3d02e14ed747e02fefc9cfabb9e36c3418/constructor/job/types.go#L171
@thanhnguyennguyen thanhnguyennguyen added the enhancement New feature or request label Nov 14, 2020
@patrick-ogrady
Copy link
Contributor

I think this is a great idea! As you mentioned, this would be a great way to limit the % of funds send in a single tx (the most common practice now is some value between 1 and max).

@raghavsharma873 raghavsharma873 mentioned this issue Apr 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 239
2 participants
@patrick-ogrady @thanhnguyennguyen