Support reanimated 3.3.0 & Expo 0.49 in example #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added comment for snapToPoint that this only works on React Native. This is due to how the cursor functions on web and apparently issues with useAnimatedGestureHandler not firing until user presses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly - thanks @Amurmurmur for their work on the following PR that helped resolve an issue I had with line interpolation in Reanimated 3.x
#149
Is based off of #148, which has a simple package fix that resolves a crash.
Description
Adds support for react-native-reanimated 3.3.0.
Updating the x position and index while using snapToPoint was broken in reanimated 3.3.0.
This PR also improves performance of the snapToPoint functionality by moving some function calls from out of the scale function (which was being called every x position change). The changes can be seen in this file src/charts/line/Cursor.tsx
I have also updated the readme for snapToPoint prop to add a message about it only being supported in React Native. I observed it not working on web and thought this would be good to call out in the docs.