Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import React #182

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Import React #182

merged 2 commits into from
Sep 4, 2024

Conversation

honeybadger26
Copy link
Collaborator

Removing the React imports causes files to throw a React is not defined error (reported in #179). This PR reverts the removal of these imports and updates the TypeScript rules to account for this.

@arancauchi
Copy link
Collaborator

Can we go with either import * as React from 'react'; or import React from 'react';?

@honeybadger26
Copy link
Collaborator Author

Can we go with either import * as React from 'react'; or import React from 'react';?

Yep. I've gone with the latter since the React docs seem to prefer that way.

@honeybadger26 honeybadger26 merged commit 755bba6 into master Sep 4, 2024
@honeybadger26 honeybadger26 deleted the fix/react-reference-error branch September 4, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants