Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap plugin doesn't create sitemap.xml #142

Open
shelvick opened this issue Oct 3, 2017 · 3 comments
Open

Sitemap plugin doesn't create sitemap.xml #142

shelvick opened this issue Oct 3, 2017 · 3 comments

Comments

@shelvick
Copy link

shelvick commented Oct 3, 2017

The sitemap object doesn't inherit from content. Quick and easy patch works for me:

--- a/plugins/sitemap.lisp	2017-10-03 06:51:49.003216580 +0000
+++ b/plugins/sitemap.lisp	2017-10-03 06:52:04.350754494 +0000
@@ -6,6 +6,7 @@
                           #:find-all
                           #:publish
                           #:theme-fn
+			  #:content
                           #:add-document
                           #:write-document)
   (:import-from :alexandria #:hash-table-values)
@@ -13,7 +14,7 @@
 
 (in-package :coleslaw-sitemap)
 
-(defclass sitemap ()
+(defclass sitemap (content)
   ((urls :initarg :urls :reader urls)))
 
 (defmethod page-url ((object sitemap)) "sitemap.xml")
@PuercoPop
Copy link
Collaborator

@shelvick Thanks for reporting this issue. However I don't think sitemap should subclass content but rather index. From hacking.md

Roughly speaking, a POST is a blog entry and an INDEX is a
collection of POSTs or other content. An INDEX really only serves to
group a set of content objects on a page, it isn't content itself.

This used to be the case. We should probably see what is needed to restore that. I think it may be asserting a route for the sitemap in the config

@cipherself
Copy link
Contributor

This is still an issue and @shelvick's patch doesn't even work anymore.

@SerialDev
Copy link

This issue has been open for a while, any suggestions on how to move this forward quickly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants