Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default deploy method deletes everything not in the staging dir #150

Open
guicho271828 opened this issue Nov 12, 2017 · 15 comments
Open

Comments

@guicho271828
Copy link
Contributor

rsync --delete -avz ... is too dangerous as a default method. When I assumed the default deployment will just put the generated files in the target directory, the entire .git/ directory was removed.

One safer way is to remove the default deploy method, and make it enabled explicitly via e.g. rsync-deploy plugin, with possibly :exclude flags.

@equwal
Copy link
Contributor

equwal commented Jun 11, 2019

I have a pull request that makes the edits to allow users a :rsync-options in the config, which might be "--delete -a" or similar (I use it to send an sshpass command for no-entry password sending).

#171

@guicho271828
Copy link
Contributor Author

I still use coleslaw for my personal website and I hope the situation of this repository gets better.
@kingcons I have an idea of making this repository into a community-maintained coleslaw organization. What do you think?

@equwal
Copy link
Contributor

equwal commented Jun 13, 2019

I still use coleslaw for my personal website and I hope the situation of this repository gets better.
@kingcons I have an idea of making this repository into a community-maintained coleslaw organization. What do you think?

I sent an email to admin@common-lisp.net asking for them to make a coleslaw mailing list. That would be a good start at least (no reply yet) for getting more community involvement.

A traditional method is to pass on the project to another BDFL. I'd be honored to accept that, if @kingcons doesn't want to maintain the project anymore.

Either alternative is better than the project getting forked without a blessing. I see a lot of potential in Coleslaw, with an active maintainer. The Lisp REPL gives it a huge advantage over other site generators, allowing a lot more control.

@kingcons
Copy link
Collaborator

kingcons commented Jun 13, 2019

Hey folks. Sorry I'm late to the thread. I'm in favor of making the project community owned. What is the process for doing so @guicho271828? There already is a "coleslaw" user account on github but I'm sure we can figure something out.

@guicho271828
Copy link
Contributor Author

org name could be something simple like coleslaw-org , unless you want to change the repo name completely.

@guicho271828
Copy link
Contributor Author

One essential part is to have several active maintainers. I think it is right now only @PuercoPop , which I suppose you trust. I suggest giving him the privilege to add new mainteners by himself, based on the chain of trust. Another essential part of making a new organization is to make it clear to the new users that this repository is maintained by the community

@equwal
Copy link
Contributor

equwal commented Jun 13, 2019

+1 for @PuercoPop having strong permissions on the project.

@PuercoPop
Copy link
Collaborator

To be honest I haven't been really been an active maintainer for a year or so. PRs have been pilling up. Fortunately Coleslaw delivers on its promise of being easy to hack and extend so users just hack away 😬!.

I agree with @guicho271828 that the best way to move forward would be to create a GitHub organization (@coleslaw-org maybe?) so that more than one user can delegate permissions, if that is ok with you @kingcons . FWIW if it were up to me I'd give @guicho271828 commit access because I trust them.

@kingcons
Copy link
Collaborator

kingcons commented Jun 14, 2019

I have created @coleslaw-org/coleslaw and invited @PuercoPop and @guicho271828 to be members of that organization/maintainers. I trust them to invite others as they deem necessary. I am not sure what the best process is for moving over any current PRs or Github Issues. The other important next steps seem to be updating the README and quicklisp to reflect the community status of the project.

I remain surprised and pleased that so many people have found coleslaw useful, if only as a starting point for hacking into blogware that suits their needs. I hardly blog myself anymore and spend most of my "fun hacking" time on other projects. I am happy to hop in if there are design decisions the maintainers want feedback on or confusing parts of the original code. My hope is that they, and the community, feel free to change coleslaw into whatever you envision.

Please let me know what else I can do to help. <3

@guicho271828
Copy link
Contributor Author

re: myself, due to my affiliation I can't commit new changes by myself but I can help handling the pull requests. thank you @kingcons @PuercoPop for inviting me.

@guicho271828
Copy link
Contributor Author

@kingcons I noticed that the issues and PRs were not migrated to the new repository. I think you didn't move the repository ownership to the organization but just pushed to the new repo in the org.

@kingcons
Copy link
Collaborator

@guicho271828 Fixed. Thank you. I forgot there was an explicit "Transfer Owner" process on github. :)

@PuercoPop
Copy link
Collaborator

I trust them to invite others as they deem necessary.

Hey @kingcons, it appears that as members of an organization we can't invite others. Only admins can do so. https://help.github.com/en/articles/repository-permission-levels-for-an-organization

I don't see a way to give the 'invite members to the organization' permission to a team 😞

@kingcons
Copy link
Collaborator

@PuercoPop I've updated you to be an owner and am happy to do so for @guicho271828 as well if he accepts the invite. Would be nice to grant the permission to a team but it's not too hard to invite individuals and then change their role on the People page.

@guicho271828
Copy link
Contributor Author

My relocation to Boston is gradually stabilizing. can be back to active soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants